feat(io): impl Reader for std::io::Cursor#278
Merged
Conversation
cpubot
force-pushed
the
std-io-cursor-read
branch
from
3b2bd9c to
c9876f3
Compare
cpubot
force-pushed
the
std-io-cursor-read
branch
from
c9876f3 to
fd39bec
Compare
kskalski
reviewed
Mar 29, 2026
| } | ||
|
|
||
| cursor.set_position(next_pos as u64); | ||
| let inner = cursor.get_ref().as_ref(); |
Contributor
There was a problem hiding this comment.
I suppose re-borrow is typically avoided by the compiler, but maybe it would make sense to make non-mutating function returning (buf, new_pos) and let the callers set position? Maybe this will make copy_into_slice and take_array faster for non-trivial T impls
Contributor
Author
There was a problem hiding this comment.
A function returning (buf, new_pos) would still require a reborrow. The reference to buf would be invalidated after calling set_position.
The codegen looks good here in the examples I tested. The bounds check was elided on &inner[pos..next_pos] and I didn't see anything that would warrant changing anything
cpubot
force-pushed
the
std-io-cursor-read
branch
from
fd39bec to
31e1547
Compare
kskalski
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
ReaderforCursor<AsRef<[u8]>>, which is consistent withstd's supported implementation.