feat(io): impl Writer for std::io::Cursor#280
Merged
Conversation
cpubot
force-pushed
the
std-io-cursor-write
branch
from
e99cbe8 to
20332b8
Compare
kskalski
reviewed
Mar 29, 2026
wincode/src/io/std_write.rs
Outdated
| } | ||
|
|
||
| #[inline] | ||
| fn cursor_advance_slice<T>( |
Contributor
There was a problem hiding this comment.
it's only used in cursor_slice_as_trusted_for, I would just inject the impl there
cpubot
force-pushed
the
std-io-cursor-write
branch
from
20332b8 to
aed46ff
Compare
cpubot
force-pushed
the
std-io-cursor-write
branch
from
aed46ff to
302b9c8
Compare
kskalski
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
Writerforstd::io::Cursoracross&mut [u8][u8; N]Box<[u8]>Vec<u8>&mut Vec<u8>Which is the exact set of types implemented by
std.