enable optional subPath for dags volume mount#22323
Merged
jedcunningham merged 3 commits intoapache:mainfrom Mar 28, 2022
Merged
enable optional subPath for dags volume mount#22323jedcunningham merged 3 commits intoapache:mainfrom
jedcunningham merged 3 commits intoapache:mainfrom
Conversation
Member
|
I think it's a good idea @jedcunningham ? @dstandish ? WDYT? |
potiuk
approved these changes
Mar 21, 2022
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
LGTM. But would love to hear what others think
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
jedcunningham
requested changes
Mar 25, 2022
Member
|
On second look, can you add the option to |
jedcunningham
approved these changes
Mar 28, 2022
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users may have their DAGs on a volume that includes other things and as such want to use a
subPathon the Volume Mount. This is similar to how thegitSyncVolume Mount is setup.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.