Fix action logging decorator for un/pausing events#33713
Closed
alephmelo wants to merge 2 commits intoapache:mainfrom
Closed
Fix action logging decorator for un/pausing events#33713alephmelo wants to merge 2 commits intoapache:mainfrom
alephmelo wants to merge 2 commits intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
ephraimbuddy
reviewed
Sep 3, 2023
| params = {k: v for k, v in itertools.chain(request.values.items(), request.view_args.items())} | ||
|
|
||
| if params and "is_paused" in params: | ||
| extra_fields.append(("is_paused", params["is_paused"] == "false")) |
Contributor
There was a problem hiding this comment.
Can you add a test for this fix
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback. Will do.
Contributor
There was a problem hiding this comment.
please ping us once you do and we will take a look
68 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #31871
Hey there 👋
Issue
Since logging happens before the action takes place, the
is_pausedquery param was not matching the further transformation that happened onviews.py.Worth noting
is_pausedtofields_skip_loggingbut I decided to do it because it will prevent traversing the list down the line looking for the tuple location.booltype into the correct Python equivalent:False|Truerather than"false"|"true".Happy to discuss and improve it further.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.