Remove option ot set a task instance to running state in UI#36518
Merged
jscheffl merged 2 commits intoapache:mainfrom Jan 5, 2024
Merged
Conversation
jscheffl
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
jscheffl
added
type:bug-fix
dirrao
reviewed
Jan 1, 2024
pankajkoti
approved these changes
Jan 1, 2024
Member
pankajkoti
left a comment
pankajkoti
left a comment
There was a problem hiding this comment.
Nice catch and fix 👏🏽 . Looks great to me. Would be nice to have another maintainer's review here.
eladkal
approved these changes
Jan 5, 2024
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 11, 2024
* Remove option ot set a task instance to running state in UI * Uups, fix pytests (cherry picked from commit 60aa611)
68 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the "Set to state 'running'" option from UI for Task instances. If users are using this, immediately an "Zombie task" error like the following is produced in the task logs:
See also https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/tasks.html#zombie-undead-tasks
Reason for removal is that the setting to state "running" just creates an inconsistent state in the meta database, no background activity is started. For advanced user who know what they are doing, rather the API `HTTP PATCH /dags/{dag_id}/dagRuns/{dag_run_id}/taskInstances/{task_id}' is the right way. But we should not leave a standard option in the normal user UI as this is mis-leading.
closes: #35729