Conversation
DjVinnii
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
boring-cyborg
bot
added
area:dev-tools
area:UI
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Looks good in general but have no real experience in Dutch.
@bolkedebruin or @BasPH can you make a language review?
|
@DjVinnii the translation looks good to me. There's a few cases of title case (Schakel over naar Donkere Modus) vs sentence case (Wachtend op een nieuwe poging). I suggest we stick with one convention. AFAIK title case doesn't really exist in Dutch, so I suggest sentence case everywhere. |
DjVinnii
force-pushed
the
add-dutch-ui-translation
branch
from
c8fe5a6 to
7288e42
Compare
DjVinnii
force-pushed
the
add-dutch-ui-translation
branch
from
7288e42 to
f6d72c1
Compare
|
Thanks @DjVinnii Alle nederlanders zijn weer blij ;-) |
| { code: "de", name: "Deutsch" }, | ||
| { code: "en", name: "English" }, | ||
| { code: "ko", name: "한국어" }, | ||
| { code: "nl", name: "Nederlands" }, |
There was a problem hiding this comment.
Mhm is this correct? Thisis not the "country code" but the name of the language. Does it need to be "Dutch"?
There was a problem hiding this comment.
@jscheffl If all the names should be in English, then yes. However, to me it seems like the name in here should be the in represented language.
There was a problem hiding this comment.
It looks correct to me
4 participants
Add Dutch UI translations.
related: #50930 & #50863
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.