Skip to content

Enable ruff PLW0127 rule #57298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jscheffl merged 1 commit into from
Oct 26, 2025
Merged

Enable ruff PLW0127 rule #57298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions airflow-core/src/airflow/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

import atexit
import functools
import json
import json as json_lib
import logging
import os
import sys
Expand Down Expand Up @@ -122,7 +122,7 @@
AsyncSession: Callable[..., SAAsyncSession]

# The JSON library to use for DAG Serialization and De-Serialization
json = json
json = json_lib

# Display alerts on the dashboard
# Useful for warning about setup issues or announcing changes to end users
Expand Down
2 changes: 1 addition & 1 deletion providers/common/sql/tests/unit/common/sql/operators/test_sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ def test_fail_all_checks_check(self, monkeypatch):
("X", "min", -1),
("X", "max", 20),
]
operator = operator = self._construct_operator(monkeypatch, self.valid_column_mapping, records)
operator = self._construct_operator(monkeypatch, self.valid_column_mapping, records)
with pytest.raises(AirflowException):
operator.execute(context=MagicMock())

Expand Down
2 changes: 2 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,8 @@ extend-select = [
"TID25", # flake8-tidy-imports rules
"E", # pycodestyle rules
"W", # pycodestyle rules
# Warning (PLW) re-implemented in ruff from Pylint
"PLW0127", # Self-assignment of variable
# Per rule enables
"RUF006", # Checks for asyncio dangling task
"RUF015", # Checks for unnecessary iterable allocation for first element
Expand Down
Loading