Skip to content

Fix ingress Helm Chart notes generation#59122

Merged
potiuk merged 2 commits intoapache:mainfrom
Miretpl:fix-notes-ingress
Dec 7, 2025
Merged

Fix ingress Helm Chart notes generation#59122
potiuk merged 2 commits intoapache:mainfrom
Miretpl:fix-notes-ingress

Conversation

@Miretpl
Copy link
Contributor

@Miretpl Miretpl commented Dec 5, 2025

The goal of this change is to properly generate NOTES during Helm Chart installation/upgrade. This PR fixes issues:

  1. Possible duplicates of / at the end of the address
  2. Not generating hosts when hosts[*].tls.enabled parameter is equal to false

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Dec 5, 2025
@potiuk potiuk merged commit 7446e41 into apache:main Dec 7, 2025
87 checks passed
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

amoghrajesh pushed a commit to astronomer/airflow that referenced this pull request Dec 8, 2025
@Miretpl Miretpl deleted the fix-notes-ingress branch December 8, 2025 16:58
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants