Refactor DateRangeFilter tests to improve input validation coverage#60029
Merged
shahar1 merged 1 commit intoapache:mainfrom Jan 3, 2026
Merged
Refactor DateRangeFilter tests to improve input validation coverage#60029shahar1 merged 1 commit intoapache:mainfrom
shahar1 merged 1 commit intoapache:mainfrom
Conversation
arjav1528
requested review from
bbovenzi,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
shahar1
approved these changes
Jan 2, 2026
arjav1528
force-pushed
the
main
branch
2 times, most recently
from
36628f0 to
8df8a3f
Compare
arjav1528
requested review from
amoghrajesh,
ashb,
kaxil and
mobuchowski
as code owners
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
henry3260
pushed a commit
to henry3260/airflow
that referenced
this pull request
Jan 3, 2026
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
jhgoebbert
pushed a commit
to jhgoebbert/airflow_Owen-CH-Leung
that referenced
this pull request
Feb 8, 2026
Subham-KRLX
pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the test coverage and assertion clarity for the date range picker component.
The changes focus on strengthening existing tests by adding explicit assertions, removing unnecessary conditional checks, and covering previously untested edge cases such as invalid dates and times, leap year handling, boundary transitions, and partial date ranges. Additional scenarios verify correct callback behavior (onChange, onRemove), display value formatting, and proper clearing of validation errors.
No production logic is modified. This change is limited to test improvements and aims to reduce the risk of regressions while improving test readability and maintainability.
related: #59949