Skip to content

Remove some global variables in airflow.settings#61356

Closed
jscheffl wants to merge 2 commits intoapache:mainfrom
jscheffl:bugfix/remove-some-global-in-settings
Closed

Remove some global variables in airflow.settings#61356
jscheffl wants to merge 2 commits intoapache:mainfrom
jscheffl:bugfix/remove-some-global-in-settings

Conversation

@jscheffl
Copy link
Contributor

@jscheffl jscheffl commented Feb 2, 2026

Another small increment to remove global statements for PR #58116

This removes (some - not all) global statements from settings.py where the a lot of state was hold in variables used with global and then a lot of code way relying to access these globals. Is a like a public interface and refactoring would be needed. Attempting to re-sort initialization order to get rid of global.

global is evil.

Note that usage of glocal in ORM engine will be a separate PR


Was generative AI tooling used to co-author this PR?
  • No (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@jscheffl jscheffl added full tests needed We need to run full set of tests for this PR to merge all versions If set, the CI build will be forced to use all versions of Python/K8S/DBs labels Feb 2, 2026
@jscheffl jscheffl closed this Feb 2, 2026
@jscheffl jscheffl reopened this Feb 2, 2026
@jscheffl
Copy link
Contributor Author

jscheffl commented Feb 7, 2026

Need some other attempt...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

all versions If set, the CI build will be forced to use all versions of Python/K8S/DBs full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant