Skip to content

fix(docker): log groomer clean-logs.sh script#63421

Merged
potiuk merged 1 commit intoapache:mainfrom
n-badtke-cg:fix/docker-clean-logs-script
Mar 12, 2026
Merged

fix(docker): log groomer clean-logs.sh script#63421
potiuk merged 1 commit intoapache:mainfrom
n-badtke-cg:fix/docker-clean-logs-script

Conversation

@n-badtke-cg
Copy link
Contributor

@n-badtke-cg n-badtke-cg commented Mar 12, 2026

commit de01a6b included changes that unfortunately:

  1. broke the script completely
  2. broke the LOG_MAX_SIZE_BYTES functionality added with commit 1e5f789

follow up PR for #61855


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

commit de01a6b included changed that unfortunately:
1. broke the script completely
2. broke the LOG_MAX_SIZE_BYTES functionality added with commit 1e5f789
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 12, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Mar 12, 2026

Nice. Thanks for fixing those !

@potiuk potiuk merged commit a268ae6 into apache:main Mar 12, 2026
9 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 12, 2026

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@github-actions
Copy link

Backport failed to create: v3-1-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-1-test Commit Link

You can attempt to backport this manually by running:

cherry_picker a268ae6 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

@n-badtke-cg
Copy link
Contributor Author

@potiuk

regarding #63421 (comment)

there are messages regarding "merge conflict on Dockerfile and clean-log.sh" but I based my fix branch on main?

@n-badtke-cg n-badtke-cg deleted the fix/docker-clean-logs-script branch March 12, 2026 13:40
Pyasma pushed a commit to Pyasma/airflow that referenced this pull request Mar 13, 2026
commit de01a6b included changed that unfortunately:
1. broke the script completely
2. broke the LOG_MAX_SIZE_BYTES functionality added with commit 1e5f789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools area:production-image Production image improvements and fixes backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants