More restrictive chart rendering logic#63464
Merged
jscheffl merged 11 commits intoapache:mainfrom Mar 12, 2026
Merged
Conversation
Miretpl
requested review from
bugraoz93,
dstandish,
hussein-awala,
jedcunningham and
jscheffl
as code owners
Contributor
Author
|
Not sure how the current run will be, but in general, static checks are failing due to the AGENTS.md file (so unrelated to this PR changes). I saw that there is a PR to fix for that already |
Contributor
Author
|
Saw that the fix for the static check was merged, so it should be good now. |
jscheffl
approved these changes
Mar 12, 2026
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Looks good! Let's have CI green and then...
Pyasma
pushed a commit
to Pyasma/airflow
that referenced
this pull request
Mar 13, 2026
* Fix api server hpa render * Fix keda enabled if for pgbouncer network policy * Fix rendering of flower-secret * Fix pgbouncer certificate secret rendering * Fix kerberos keytab secret rendering * Refactor scc rolebinding tests * Fix scc rolebanding rendering
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While checking the chart for unremoved items after #61018, I noticed that we actually have some missing conditional logic or inconsistent places.
This PR consists of changes in the rendering conditions for various places in the chart:
Additional changes to the above-mentioned are:
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.