chore: Add CI#17
Conversation
|
CI result on my fork: https://github.com/kou/arrow-dotnet/actions/runs/16986434875/job/48156245498 |
| This folder contains binary protocol definitions for the Arrow columnar format | ||
| and other parts of the project, like the Flight RPC framework. | ||
|
|
||
| This is a copy of https://github.com/apache/arrow/tree/main/format . |
There was a problem hiding this comment.
Would it make sense for these format files to live in a new arrow-format repository, so they can be included as a submodule and kept up to date in one place rather than need to be manually updated?
I briefly looked at other Arrow implementation repositories (go, swift, js, rust) and as far as I can tell only the Rust implementation also has a copy of these files. I guess this is because the other implementations have checked in the generated code, or they use hand-written implementations rather than generated code.
These files probably won't change very often though so I think it's fine to store copies here and manually update files as needed. And if we did want to change this, it should be a follow-up change and not block this PR.
There was a problem hiding this comment.
Let's discuss it in dev@arrow.apache.org.
Could you start a thread in the mailing list.
Let's copy these files for now.
2 participants
What's Changed
This is based on https://github.com/apache/arrow/blob/main/.github/workflows/csharp.yml but packaging job isn't included. Let's work on it as a separated task.
This copies https://github.com/apache/arrow/tree/main/format to
format/.This copies scripts:
Closes #7.