chore: Check format in CI

.pre-commit-config.yaml

@@ -35,3 +35,10 @@ repos:
             rm -f apache-arrow-dotnet.tar.gz"
         always_run: true
         pass_filenames: false
+      - id: format
+        name: Format
+        language: system
+        entry: |
+          dotnet format --exclude src/Apache.Arrow/Flatbuf/FlatBuffers/
+        always_run: true
+        pass_filenames: false

src/Apache.Arrow.Compression/Lz4CompressionCodec.cs

@@ -33,7 +33,7 @@ public Lz4CompressionCodec(int? compressionLevel = null)
                 {
                     _settings = new LZ4EncoderSettings
                     {
-                        CompressionLevel = (LZ4Level) compressionLevel
+                        CompressionLevel = (LZ4Level)compressionLevel
                     };
                 }
                 else

src/Apache.Arrow.Flight.Sql/DoPutResult.cs

@@ -30,7 +30,7 @@ public DoPutResult(FlightClientRecordBatchStreamWriter writer, IAsyncStreamReade
         Writer = writer;
         Reader = reader;
     }
-    
+
     /// <summary>
     /// Reads the metadata asynchronously from the reader.
     /// </summary>
@@ -43,7 +43,7 @@ public DoPutResult(FlightClientRecordBatchStreamWriter writer, IAsyncStreamReade
         }
         throw new RpcException(new Status(StatusCode.Internal, "No metadata available in the response stream."));
     }
-    
+
     /// <summary>
     /// Completes the writer by signaling the end of the writing process.
     /// </summary>

src/Apache.Arrow.Flight.Sql/FlightCallOptions.cs

@@ -26,7 +26,7 @@ public FlightCallOptions()
     {
         Timeout = TimeSpan.FromSeconds(-1);
     }
-    
+
     // Implement any necessary options for RPC calls
     public Metadata Headers { get; set; } = new();
 

src/Apache.Arrow.Flight.Sql/FlightExtensions.cs

@@ -38,4 +38,4 @@ public static int ExtractRowCount(this RecordBatch batch)
 
         return length;
     }
-}
+}

src/Apache.Arrow.Flight.Sql/FlightSqlServer.cs

@@ -30,9 +30,9 @@ namespace Apache.Arrow.Flight.Sql;
 public abstract class FlightSqlServer : FlightServer
 {
     private ILogger? Logger { get; }
-    public static readonly Schema CatalogSchema = new(new List<Field> {new("catalog_name", StringType.Default, false)}, null);
-    public static readonly Schema TableTypesSchema = new(new List<Field> {new("table_type", StringType.Default, false)}, null);
-    public static readonly Schema DbSchemaFlightSchema = new(new List<Field> {new("catalog_name", StringType.Default, true), new("db_schema_name", StringType.Default, false)}, null);
+    public static readonly Schema CatalogSchema = new(new List<Field> { new("catalog_name", StringType.Default, false) }, null);
+    public static readonly Schema TableTypesSchema = new(new List<Field> { new("table_type", StringType.Default, false) }, null);
+    public static readonly Schema DbSchemaFlightSchema = new(new List<Field> { new("catalog_name", StringType.Default, true), new("db_schema_name", StringType.Default, false) }, null);
 
     public static readonly Schema PrimaryKeysSchema = new(new List<Field>
     {

src/Apache.Arrow.Flight.Sql/PreparedStatement.cs

@@ -230,10 +230,10 @@ public async Task<FlightInfo> ExecuteAsync(FlightCallOptions? options = default,
         {
             PreparedStatementHandle = ByteString.CopyFrom(_handle, Encoding.UTF8),
         };
-        
+
         var descriptor = FlightDescriptor.CreateCommandDescriptor(command.PackAndSerialize());
         cancellationToken.ThrowIfCancellationRequested();
-        
+
         if (_recordsBatch != null)
         {
             await BindParametersAsync(descriptor, _recordsBatch, options, cancellationToken).ConfigureAwait(false);
@@ -286,7 +286,7 @@ public async Task<long> ExecuteUpdateAsync(
         {
             throw new ArgumentNullException(nameof(parameterBatch), "Parameter batch cannot be null.");
         }
-        
+
         var command = new CommandPreparedStatementQuery
         {
             PreparedStatementHandle = ByteString.CopyFrom(_handle, Encoding.UTF8),

src/Apache.Arrow.Flight.Sql/SchemaExtensions.cs

@@ -35,16 +35,16 @@ public static Schema DeserializeSchema(ReadOnlyMemory<byte> serializedSchema)
         using var reader = new ArrowStreamReader(serializedSchema);
         return reader.Schema;
     }
-    
+
     /// <summary>
     /// Serializes the provided schema to a byte array.
     /// </summary>
     public static byte[] SerializeSchema(Schema schema)
     {
         using var memoryStream = new MemoryStream();
         using var writer = new ArrowStreamWriter(memoryStream, schema);
-        writer.WriteStart(); 
+        writer.WriteStart();
         writer.WriteEnd();
         return memoryStream.ToArray();
     }
-}
+}

src/Apache.Arrow.Flight/Client/FlightClientRecordBatchStreamReader.cs

@@ -13,8 +13,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-using Apache.Arrow.Flight.Protocol;
 using Apache.Arrow.Flight.Internal;
+using Apache.Arrow.Flight.Protocol;
 using Grpc.Core;
 
 namespace Apache.Arrow.Flight.Client

src/Apache.Arrow.Flight/Client/FlightClientRecordBatchStreamWriter.cs

@@ -17,8 +17,8 @@
 using System.Collections.Generic;
 using System.Text;
 using System.Threading.Tasks;
-using Apache.Arrow.Flight.Protocol;
 using Apache.Arrow.Flight.Internal;
+using Apache.Arrow.Flight.Protocol;
 using Grpc.Core;
 
 namespace Apache.Arrow.Flight.Client

src/Apache.Arrow.Flight/Client/FlightRecordBatchExchangeCall.cs

@@ -14,8 +14,8 @@
 // limitations under the License.
 
 using System;
-using Grpc.Core;
 using System.Threading.Tasks;
+using Grpc.Core;
 
 namespace Apache.Arrow.Flight.Client
 {

src/Apache.Arrow.Flight/Extensions/FlightInfoExtensions.cs

@@ -21,7 +21,7 @@ namespace Apache.Arrow.Flight.Extensions
     public static class FlightInfoExtensions
     {
         public static ByteString ToByteString(this FlightInfo flightInfo)
-        { 
+        {
             return flightInfo.ToProtocol().ToByteString();
         }
     }

src/Apache.Arrow.Flight/FlightActionType.cs

@@ -46,7 +46,7 @@ internal Protocol.ActionType ToProtocol()
 
         public override bool Equals(object obj)
         {
-            if(obj is FlightActionType other)
+            if (obj is FlightActionType other)
             {
                 return Equals(_actionType, other._actionType);
             }

src/Apache.Arrow.Flight/FlightDescriptor.cs

@@ -41,7 +41,7 @@ private FlightDescriptor(params string[] paths)
                 Type = Protocol.FlightDescriptor.Types.DescriptorType.Path
             };
 
-            foreach(var path in paths)
+            foreach (var path in paths)
             {
                 _flightDescriptor.Path.Add(path);
             }
@@ -66,7 +66,7 @@ public static FlightDescriptor CreatePathDescriptor(params string[] paths)
 
         internal FlightDescriptor(Protocol.FlightDescriptor flightDescriptor)
         {
-            if(flightDescriptor.Type != Protocol.FlightDescriptor.Types.DescriptorType.Cmd && flightDescriptor.Type != Protocol.FlightDescriptor.Types.DescriptorType.Path)
+            if (flightDescriptor.Type != Protocol.FlightDescriptor.Types.DescriptorType.Cmd && flightDescriptor.Type != Protocol.FlightDescriptor.Types.DescriptorType.Path)
             {
                 throw new NotSupportedException();
             }
@@ -92,7 +92,7 @@ public override int GetHashCode()
 
         public override bool Equals(object obj)
         {
-            if(obj is FlightDescriptor other)
+            if (obj is FlightDescriptor other)
             {
                 return Equals(_flightDescriptor, other._flightDescriptor);
             }

src/Apache.Arrow.Flight/FlightEndpoint.cs

@@ -47,7 +47,7 @@ internal Protocol.FlightEndpoint ToProtocol()
                 Ticket = _ticket.ToProtocol()
             };
 
-            foreach(var location in _locations)
+            foreach (var location in _locations)
             {
                 output.Location.Add(location.ToProtocol());
             }
@@ -56,7 +56,7 @@ internal Protocol.FlightEndpoint ToProtocol()
 
         public override bool Equals(object obj)
         {
-            if(obj is FlightEndpoint other)
+            if (obj is FlightEndpoint other)
             {
                 return Equals(_ticket, other._ticket) &&
                     Enumerable.SequenceEqual(_locations, other._locations);

src/Apache.Arrow.Flight/FlightHandshakeRequest.cs

@@ -44,7 +44,7 @@ internal Protocol.HandshakeRequest ToProtocol()
 
     public override bool Equals(object obj)
     {
-        if(obj is FlightHandshakeRequest other)
+        if (obj is FlightHandshakeRequest other)
         {
             return Equals(_result, other._result);
         }

src/Apache.Arrow.Flight/FlightInfo.cs

@@ -30,7 +30,7 @@ internal FlightInfo(Protocol.FlightInfo flightInfo)
             Descriptor = new FlightDescriptor(flightInfo.FlightDescriptor);
 
             var endpoints = new List<FlightEndpoint>();
-            foreach(var endpoint in flightInfo.Endpoint)
+            foreach (var endpoint in flightInfo.Endpoint)
             {
                 endpoints.Add(new FlightEndpoint(endpoint));
             }
@@ -41,11 +41,11 @@ internal FlightInfo(Protocol.FlightInfo flightInfo)
             Ordered = flightInfo.Ordered;
             AppMetadata = flightInfo.AppMetadata;
         }
-        public FlightInfo(Schema schema, FlightDescriptor descriptor, IReadOnlyList<FlightEndpoint> endpoints, long totalRecords = -1, long totalBytes = -1):this(schema,descriptor,endpoints,totalRecords,totalBytes,false, ByteString.Empty)
+        public FlightInfo(Schema schema, FlightDescriptor descriptor, IReadOnlyList<FlightEndpoint> endpoints, long totalRecords = -1, long totalBytes = -1) : this(schema, descriptor, endpoints, totalRecords, totalBytes, false, ByteString.Empty)
         {
         }
 
-        public FlightInfo(Schema schema, FlightDescriptor descriptor, IReadOnlyList<FlightEndpoint> endpoints, long totalRecords, long totalBytes, bool ordered = false, ByteString appMetadata=null)
+        public FlightInfo(Schema schema, FlightDescriptor descriptor, IReadOnlyList<FlightEndpoint> endpoints, long totalRecords, long totalBytes, bool ordered = false, ByteString appMetadata = null)
         {
             Schema = schema;
             Descriptor = descriptor;
@@ -81,7 +81,7 @@ internal Protocol.FlightInfo ToProtocol()
                 TotalBytes = TotalBytes,
                 TotalRecords = TotalRecords,
                 Ordered = Ordered,
-                AppMetadata = AppMetadata 
+                AppMetadata = AppMetadata
             };
 
             foreach (var endpoint in Endpoints)

src/Apache.Arrow.Flight/FlightLocation.cs

@@ -44,7 +44,7 @@ internal Protocol.Location ToProtocol()
 
         public override bool Equals(object obj)
         {
-            if(obj is FlightLocation other)
+            if (obj is FlightLocation other)
             {
                 return Equals(_location, other._location);
             }

src/Apache.Arrow.Flight/FlightResult.cs

@@ -56,7 +56,7 @@ internal Protocol.Result ToProtocol()
 
         public override bool Equals(object obj)
         {
-            if(obj is FlightResult other)
+            if (obj is FlightResult other)
             {
                 return Equals(_result, other._result);
             }

src/Apache.Arrow.Flight/FlightTicket.cs

@@ -55,7 +55,7 @@ internal Protocol.Ticket ToProtocol()
 
         public override bool Equals(object obj)
         {
-            if(obj is FlightTicket other)
+            if (obj is FlightTicket other)
             {
                 return Equals(_ticket, other._ticket);
             }

src/Apache.Arrow.Flight/Internal/FlightDataStream.cs

@@ -48,7 +48,7 @@ public async Task SendSchema()
         {
             _currentFlightData = new Protocol.FlightData();
 
-            if(_flightDescriptor != null)
+            if (_flightDescriptor != null)
             {
                 _currentFlightData.FlightDescriptor = _flightDescriptor.ToProtocol();
             }
@@ -76,7 +76,7 @@ public async Task Write(RecordBatch recordBatch, ByteString applicationMetadata)
 
             _currentFlightData = new Protocol.FlightData();
 
-            if(applicationMetadata != null)
+            if (applicationMetadata != null)
             {
                 _currentFlightData.AppMetadata = applicationMetadata;
             }

src/Apache.Arrow.Flight/Internal/RecordBatchReaderImplementation.cs

@@ -84,7 +84,7 @@ public override async ValueTask ReadSchemaAsync(CancellationToken cancellationTo
 
                 // AppMetadata will never be null, but length 0 if empty
                 // Those are skipped
-                if(_flightDataStream.Current.AppMetadata.Length > 0)
+                if (_flightDataStream.Current.AppMetadata.Length > 0)
                 {
                     _applicationMetadatas.Add(_flightDataStream.Current.AppMetadata);
                 }

src/Apache.Arrow.Flight/Internal/SchemaWriter.cs

@@ -43,7 +43,7 @@ public void WriteSchema(Schema schema, CancellationToken cancellationToken)
 
         public static ByteString SerializeSchema(Schema schema, CancellationToken cancellationToken = default(CancellationToken))
         {
-            using(var memoryStream = new MemoryStream())
+            using (var memoryStream = new MemoryStream())
             {
                 var writer = new SchemaWriter(memoryStream, schema);
                 writer.WriteSchema(schema, cancellationToken);

src/Apache.Arrow/Arrays/ArrayData.cs

@@ -13,11 +13,11 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-using Apache.Arrow.Memory;
-using Apache.Arrow.Types;
 using System;
 using System.Collections.Generic;
 using System.Linq;
+using Apache.Arrow.Memory;
+using Apache.Arrow.Types;
 
 namespace Apache.Arrow
 {

src/Apache.Arrow/Arrays/ArrayDataConcatenator.cs

@@ -13,11 +13,11 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+using System;
+using System.Collections.Generic;
 using Apache.Arrow.Memory;
 using Apache.Arrow.Scalars;
 using Apache.Arrow.Types;
-using System;
-using System.Collections.Generic;
 
 namespace Apache.Arrow
 {
@@ -329,11 +329,11 @@ private ArrowBuffer ConcatenateValidityBuffer()
                     {
                         if (arrayData.NullCount == 0)
                         {
-                            builder.AppendRange(true , length);
+                            builder.AppendRange(true, length);
                         }
                         else if (arrayData.NullCount == length)
                         {
-                            builder.AppendRange(false , length);
+                            builder.AppendRange(false, length);
                         }
                         else
                         {

src/Apache.Arrow/Arrays/ArrayDataTypeComparer.cs

@@ -165,7 +165,7 @@ private static bool CompareNested(NestedType expectedType, NestedType actualType
                 }
             }
 
-            return true;   
+            return true;
         }
 
         public void Visit(IArrowType actualType)

src/Apache.Arrow/Arrays/ArrowArrayBuilderFactory.cs

@@ -13,8 +13,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-using Apache.Arrow.Types;
 using System;
+using Apache.Arrow.Types;
 
 namespace Apache.Arrow
 {

src/Apache.Arrow/Arrays/ArrowArrayConcatenator.cs

@@ -13,16 +13,16 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-using Apache.Arrow.Memory;
 using System.Collections.Generic;
+using Apache.Arrow.Memory;
 
 namespace Apache.Arrow
 {
     public static class ArrowArrayConcatenator
     {
-        public static IArrowArray Concatenate(IReadOnlyList<IArrowArray> arrowArrayList , MemoryAllocator allocator = default)
+        public static IArrowArray Concatenate(IReadOnlyList<IArrowArray> arrowArrayList, MemoryAllocator allocator = default)
         {
-            if(arrowArrayList == null || arrowArrayList.Count == 0)
+            if (arrowArrayList == null || arrowArrayList.Count == 0)
             {
                 return null;
             }
@@ -34,7 +34,7 @@ public static IArrowArray Concatenate(IReadOnlyList<IArrowArray> arrowArrayList
 
             var arrayDataList = new List<ArrayData>(arrowArrayList.Count);
 
-            foreach(IArrowArray array in arrowArrayList)
+            foreach (IArrowArray array in arrowArrayList)
             {
                 arrayDataList.Add(array.Data);
             }