feat: Add arrayApproxEqualString to handle null characters in string. #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroshade
requested changes
Feb 19, 2025
Member
zeroshade
left a comment
zeroshade
left a comment
There was a problem hiding this comment.
should also add the same for StringView too please
singh1203
force-pushed
the
ApproxEqStr
branch
from
44d8ad3 to
1d07d32
Compare
Contributor
Author
Added! |
singh1203
commented
Feb 20, 2025
…ers in strings Signed-off-by: Saurabh Kumar Singh <[email protected]>
singh1203
force-pushed
the
ApproxEqStr
branch
from
1d07d32 to
d579bfc
Compare
Contributor
Author
|
@zeroshade I think we are GTG here. |
zeroshade
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #56
Rationale for this change
Many databases, including PostgreSQL, do not accept null characters (\x00) in strings. This PR introduces
arrayApproxEqualString&arrayApproxEqualLargeString, functions that enables approximate equality comparison for string arrays while ignoring trailing null characters. This helps improve consistency with database behavior and aligns with existing arrayApproxEqualFloat16.What changes are included in this PR?
arrayApproxEqualString:compare_test.goto verify correctness.Are these changes tested?
Yes, unit tests have been added to validate:
Are there any user-facing changes?
No