fix(parquet/pqarrow): propagate field id metadata for lists/maps #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Discovered while fixing apache/iceberg-go#309 we didn't correctly propagate the field-id metadata to children of List or Map fields, only structs.
What changes are included in this PR?
A new MapType creator for constructing MapTypes from arrow fields for the Key and Items for easier construction, and fixing the
pqarrowschema manifest creation to correctly propagate the child metadata field IDs for the children.Are these changes tested?
Unit test is added.
Are there any user-facing changes?
Usage of pqarrow reading List/Map typed fields will now correctly contain the
PARQUET:field_idmetadata key in the schema produced.