feat(parquet/pqarrow): Add SeekToRow for RecordReader #321
+290
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
approved these changes
Mar 21, 2025
| // the ref count is 0. | ||
| Release() | ||
|
|
||
| SeekToRow(int64) error |
Member
There was a problem hiding this comment.
Should we add docstrings for new methods?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
As suggested by #278 (comment) allowing the RecordReader from the
pqarrowpackage to also leverage theSeekToRowfunctionality to skip records from a parquet file while respected skipping particular row groups.What changes are included in this PR?
Implementing a
SeekToRowmethod forpqarrow.RecordReaderto seek the record reader to a specific row where the next read will start from.Are these changes tested?
Yes, unit tests are added for this.
Are there any user-facing changes?
Just the new functions.