feat(parquet/metadata): bloom filter implementation #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
reviewed
Mar 31, 2025
Member
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
Some initial comments. I have yet to look at the bloom filter itself
lidavidm
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
As with many other parquet reader/writers we should add support for bloom filters.
What changes are included in this PR?
This only adds an implementation to the
metadatapackage to represent bloom filters and process them for metadata reading and writing. This does not yet wire it up through the actual parquet file reader and writer. That will be done in a subsequent PR.Are these changes tested?
Yes, unit tests are included.
Are there any user-facing changes?
Only the addition of the new functions that are exposed in the metadata package.