ci: make additional checks to prevent flaky EOF #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
approved these changes
Jun 18, 2025
| rows := 0 | ||
| for rows < maxBatchSize && r.rows.Next() { | ||
| if err := r.rows.Scan(r.rowdest...); err != nil { | ||
| if err := r.rows.Scan(r.rowdest...); err != nil && err.Error() != io.EOF.Error() { |
Member
There was a problem hiding this comment.
Huh...it's quite weird that this can return EOF
Member
Author
There was a problem hiding this comment.
From what I can tell, it's something weird with the sqlite handler implementation. it shouldn't be returning EOF, which looks like it isn't even returning io.EOF and instead just returns the string "EOF" it's really weird.
zeroshade
added a commit
to zeroshade/arrow-go
that referenced
this pull request
Jun 20, 2025
### Rationale for this change Additional checks for `io.EOF` to avoid flaky tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Additional checks for
io.EOFto avoid flaky tests