Skip to content

Support Julia 1.0 for ArrowTypes package#223

Merged
jrevels merged 3 commits intomainfrom
cv/arrow-types-compat
Jul 23, 2021
Merged

Support Julia 1.0 for ArrowTypes package#223
jrevels merged 3 commits intomainfrom
cv/arrow-types-compat

Conversation

@omus
Copy link
Copy Markdown
Contributor

@omus omus commented Jul 8, 2021

Allows for packages to depend on ArrowTypes.jl and still include support for the Julia 1.0 LTS.

@omus
Copy link
Copy Markdown
Contributor Author

omus commented Jul 8, 2021

The Julia 1.0 failure is due to the build step using the Project.toml from the root of the directory while using Julia 1.0. That Project.toml wants to use ArrowTypes.jl 1.1 which requires Julia 1.3:

ERROR: Unsatisfiable requirements detected for package ArrowTypes [31f734f8]:
 ArrowTypes [31f734f8] log:
 ├─possible versions are: [1.0.0, 1.1.0] or uninstalled
 ├─restricted to versions 1.1.0-1 by an explicit requirement, leaving only versions 1.1.0
 └─restricted by julia compatibility requirements to versions: uninstalled — no versions left

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 8, 2021

Codecov Report

Merging #223 (f5b5d99) into main (536c72c) will increase coverage by 0.50%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
+ Coverage   83.11%   83.62%   +0.50%     
==========================================
  Files          26       26              
  Lines        3092     3187      +95     
==========================================
+ Hits         2570     2665      +95     
  Misses        522      522              
Impacted Files Coverage Δ
src/ArrowTypes/test/tests.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 536c72c...f5b5d99. Read the comment docs.

@omus omus requested a review from jrevels July 9, 2021 13:37
@jrevels jrevels merged commit 1595728 into main Jul 23, 2021
@jrevels jrevels deleted the cv/arrow-types-compat branch July 23, 2021 04:16
@ericphanson ericphanson mentioned this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants