Skip to content

ARROW-17496: [Go] Fix Nightly Build#13943

Merged
zeroshade merged 1 commit intoapache:masterfrom
zeroshade:arrow-17496-fix-build
Aug 22, 2022
Merged

ARROW-17496: [Go] Fix Nightly Build#13943
zeroshade merged 1 commit intoapache:masterfrom
zeroshade:arrow-17496-fix-build

Conversation

@zeroshade
Copy link
Copy Markdown
Member

Turns out that the pragma_table_info function in modernc.org/sqlite's package doesn't work correctly in go1.17 either, only in go1.18. As this is only used for testing and the example sqlite flightsql server, rather than anything needed in the flightsql package itself, the bulid failure is easily solved by marking the example and its tests to be only built in go1.18.

As we already have a git workflow that runs with go1.18, the CI will still continue to test the example code, but mamba builds using go1.17 won't break anymore.

@zeroshade
Copy link
Copy Markdown
Member Author

@github-actions crossbow submit verify-rc-source-go-*

@github-actions
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

No such command 'crossbow-submit'.
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/2905354072

@github-actions
Copy link
Copy Markdown

Revision: 1a9f33c

Submitted crossbow builds: ursacomputing/crossbow @ actions-652af61a88

Task Status
verify-rc-source-go-linux-almalinux-8-amd64 Github Actions
verify-rc-source-go-linux-conda-latest-amd64 Github Actions
verify-rc-source-go-linux-ubuntu-18.04-amd64 Github Actions
verify-rc-source-go-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-go-linux-ubuntu-22.04-amd64 Github Actions
verify-rc-source-go-macos-amd64 Github Actions
verify-rc-source-go-macos-arm64 Github Actions

@zeroshade
Copy link
Copy Markdown
Member Author

@github-actions crossbow submit verify-rc-source-integration-*

@github-actions
Copy link
Copy Markdown

Revision: 1a9f33c

Submitted crossbow builds: ursacomputing/crossbow @ actions-42a6bfa674

Task Status
verify-rc-source-integration-linux-almalinux-8-amd64 Github Actions
verify-rc-source-integration-linux-conda-latest-amd64 Github Actions
verify-rc-source-integration-linux-ubuntu-18.04-amd64 Github Actions
verify-rc-source-integration-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-integration-linux-ubuntu-22.04-amd64 Github Actions
verify-rc-source-integration-macos-amd64 Github Actions
verify-rc-source-integration-macos-arm64 Github Actions
verify-rc-source-integration-macos-conda-amd64 Github Actions

@github-actions
Copy link
Copy Markdown

Revision: 1a9f33c

Submitted crossbow builds: ursacomputing/crossbow @ actions-d2e6be8659

Task Status
verify-rc-source-integration-linux-almalinux-8-amd64 Github Actions
verify-rc-source-integration-linux-conda-latest-amd64 Github Actions
verify-rc-source-integration-linux-ubuntu-18.04-amd64 Github Actions
verify-rc-source-integration-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-integration-linux-ubuntu-22.04-amd64 Github Actions
verify-rc-source-integration-macos-amd64 Github Actions
verify-rc-source-integration-macos-arm64 Github Actions
verify-rc-source-integration-macos-conda-amd64 Github Actions

@zeroshade
Copy link
Copy Markdown
Member Author

The failing verify-rc-source-integration-macos-conda-amd64 is failing with a flightsql timeout on the C++ build, it's unrelated to this issue. @raulcd is this a different issue you filed? or otherwise know about? ie. should it prevent this fix from being submitted?

@zeroshade
Copy link
Copy Markdown
Member Author

@github-actions crossbow submit verify-rc-source-integration-macos-conda-amd64

@github-actions
Copy link
Copy Markdown

Revision: 1a9f33c

Submitted crossbow builds: ursacomputing/crossbow @ actions-f4984f7e08

Task Status
verify-rc-source-integration-macos-conda-amd64 Github Actions

@raulcd
Copy link
Copy Markdown
Member

raulcd commented Aug 22, 2022

@raulcd is this a different issue you filed? or otherwise know about? ie. should it prevent this fix from being submitted?

I recall seeing this test time out before but I am not sure whether it is tracked. I do not think is related to the fix.

@zeroshade zeroshade merged commit 0600bb2 into apache:master Aug 22, 2022
@zeroshade zeroshade deleted the arrow-17496-fix-build branch August 22, 2022 23:11
@ursabot
Copy link
Copy Markdown

ursabot commented Aug 23, 2022

Benchmark runs are scheduled for baseline = 62461b0 and contender = 0600bb2. 0600bb2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️1.09% ⬆️0.07%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.53% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 0600bb27 ec2-t3-xlarge-us-east-2
[Failed] 0600bb27 test-mac-arm
[Failed] 0600bb27 ursa-i9-9960x
[Finished] 0600bb27 ursa-thinkcentre-m75q
[Finished] 62461b0a ec2-t3-xlarge-us-east-2
[Failed] 62461b0a test-mac-arm
[Failed] 62461b0a ursa-i9-9960x
[Finished] 62461b0a ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
Turns out that the `pragma_table_info` function in modernc.org/sqlite's package doesn't work correctly in go1.17 either, only in go1.18. As this is only used for testing and the example sqlite flightsql server, rather than anything needed in the flightsql package itself, the bulid failure is easily solved by marking the example and its tests to be only built in go1.18.

As we already have a git workflow that runs with go1.18, the CI will still continue to test the example code, but mamba builds using go1.17 won't break anymore.

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants