GH-46988: [C++][Parquet] Fix FLBA DecodeArrow multiply overflow#46991
Merged
mapleFU merged 2 commits intoapache:mainfrom Jul 4, 2025
Merged
GH-46988: [C++][Parquet] Fix FLBA DecodeArrow multiply overflow#46991mapleFU merged 2 commits intoapache:mainfrom
mapleFU merged 2 commits intoapache:mainfrom
Conversation
|
|
github-actions
Bot
added
Component: Parquet
Component: C++
awaiting review
Member
Author
|
@pitrou It's an old problem, so maybe we can fix it after 21.0? |
Member
|
Can you first add the regression file to arrow-testing? |
pitrou
reviewed
Jul 4, 2025
| } | ||
| } | ||
|
|
||
| void checkPageOverflow(int32_t remain, int32_t arg1, int32_t arg2) { |
Member
There was a problem hiding this comment.
Several suggestions at once: 1) respect naming convention 2) make argument names more explicit 3) take int64_t, implicit widening will take place when calling with int32_t
Suggested change
| void checkPageOverflow(int32_t remain, int32_t arg1, int32_t arg2) { | |
| void CheckPageLargeEnough(int64_t remaining_bytes, int32_t value_width, int64_t num_values) { |
Member
|
Also, thanks a lot for tackling this! |
pitrou
added
the
Critical Fix
github-actions
Bot
added
awaiting committer review
Member
Author
|
Testing file: apache/arrow-testing#107 |
pitrou
approved these changes
Jul 4, 2025
mapleFU
changed the title
amoeba
removed
the
Critical Fix
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit aa45c12. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See: #46988
Note that it's an old problem, not a new problem
What changes are included in this PR?
Add
checkPageOverflowAre these changes tested?
By arrow-testing file
Are there any user-facing changes?
No, just a minor bugfix