GH-48248: [C++] Use FetchContent for bundled gRPC by raulcd · Pull Request #48250 · apache/arrow

raulcd · 2025-11-25T11:04:08Z

Rationale for this change

As a follow up of requiring a minimum CMake version >= 3.25 we discussed moving our dependencies from ExternalProject to FetchContent. This can simplify our third party dependency management.

What changes are included in this PR?

The general change is moving gRPC from ExternalProject to FetchContent.

We can clean up previously required installation on RE2 and C-Ares. We can't do it for Abseil or protobuf as those are also used on other dependencies. We will be able to clean those later.

Are these changes tested?

Yes, the changes are tested locally and on CI.

Are there any user-facing changes?

No

GitHub Issue: [C++] Use FetchContent for bundled gRPC #48248

raulcd · 2025-11-25T12:20:39Z

@github-actions crossbow submit -g cpp

github-actions · 2025-11-25T12:24:07Z

Revision: 9386a28

Submitted crossbow builds: ursacomputing/crossbow @ actions-bbf70f60fe

Task	Status
example-cpp-minimal-build-static
example-cpp-minimal-build-static-system-dependency
example-cpp-tutorial
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1
test-debian-12-cpp-amd64
test-debian-12-cpp-i386
test-fedora-42-cpp
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-20
test-ubuntu-22.04-cpp-bundled
test-ubuntu-22.04-cpp-emscripten
test-ubuntu-22.04-cpp-no-threading
test-ubuntu-24.04-cpp
test-ubuntu-24.04-cpp-bundled-offline
test-ubuntu-24.04-cpp-gcc-13-bundled
test-ubuntu-24.04-cpp-gcc-14
test-ubuntu-24.04-cpp-minimal-with-formats
test-ubuntu-24.04-cpp-thread-sanitizer

raulcd · 2025-11-25T13:21:39Z

@github-actions crossbow submit -g r

github-actions · 2025-11-25T13:24:34Z

Revision: 9386a28

Submitted crossbow builds: ursacomputing/crossbow @ actions-b3bd179582

Task	Status
r-binary-packages
r-recheck-most
test-r-arrow-backwards-compatibility
test-r-depsource-bundled
test-r-depsource-system
test-r-dev-duckdb
test-r-devdocs
test-r-extra-packages
test-r-gcc-11
test-r-gcc-12
test-r-install-local
test-r-install-local-minsizerel
test-r-linux-as-cran
test-r-linux-rchk
test-r-linux-sanitizers
test-r-linux-valgrind
test-r-m1-san
test-r-macos-as-cran
test-r-minimal-build
test-r-offline-maximal
test-r-offline-minimal
test-r-rhub-debian-gcc-devel-lto-latest
test-r-rhub-ubuntu-gcc12-custom-ccache
test-r-rhub-ubuntu-release-latest
test-r-rocker-r-ver-latest
test-r-rstudio-r-base-4.1-focal
test-r-rstudio-r-base-4.2-focal
test-r-ubuntu-22.04
test-r-versions

raulcd · 2025-11-26T13:57:10Z

@github-actions crossbow submit -g cpp

github-actions · 2025-11-26T13:59:41Z

Revision: 1144f25

Submitted crossbow builds: ursacomputing/crossbow @ actions-c9de41cc83

Task	Status
example-cpp-minimal-build-static
example-cpp-minimal-build-static-system-dependency
example-cpp-tutorial
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1
test-debian-12-cpp-amd64
test-debian-12-cpp-i386
test-fedora-42-cpp
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-20
test-ubuntu-22.04-cpp-bundled
test-ubuntu-22.04-cpp-emscripten
test-ubuntu-22.04-cpp-no-threading
test-ubuntu-24.04-cpp
test-ubuntu-24.04-cpp-bundled-offline
test-ubuntu-24.04-cpp-gcc-13-bundled
test-ubuntu-24.04-cpp-gcc-14
test-ubuntu-24.04-cpp-minimal-with-formats
test-ubuntu-24.04-cpp-thread-sanitizer

raulcd · 2025-11-26T15:46:49Z

@github-actions crossbow submit test-ubuntu-22.04-cpp-bundled

github-actions · 2025-11-26T15:49:05Z

Revision: 9bddf67

Submitted crossbow builds: ursacomputing/crossbow @ actions-de489c8583

Task	Status
test-ubuntu-22.04-cpp-bundled

raulcd · 2025-11-26T15:58:25Z

@github-actions crossbow submit -g r

github-actions · 2025-11-26T16:01:38Z

Revision: 9bddf67

Submitted crossbow builds: ursacomputing/crossbow @ actions-3f45b50a5c

Task	Status
r-binary-packages
r-recheck-most
test-r-arrow-backwards-compatibility
test-r-depsource-bundled
test-r-depsource-system
test-r-dev-duckdb
test-r-devdocs
test-r-extra-packages
test-r-gcc-11
test-r-gcc-12
test-r-install-local
test-r-install-local-minsizerel
test-r-linux-as-cran
test-r-linux-rchk
test-r-linux-sanitizers
test-r-linux-valgrind
test-r-m1-san
test-r-macos-as-cran
test-r-minimal-build
test-r-offline-maximal
test-r-offline-minimal
test-r-rhub-debian-gcc-devel-lto-latest
test-r-rhub-ubuntu-gcc12-custom-ccache
test-r-rhub-ubuntu-release-latest
test-r-rocker-r-ver-latest
test-r-rstudio-r-base-4.1-focal
test-r-rstudio-r-base-4.2-focal
test-r-ubuntu-22.04
test-r-versions

raulcd · 2025-11-26T17:26:31Z

@github-actions crossbow submit -g cpp

github-actions · 2025-11-26T17:29:06Z

Revision: 9bddf67

Submitted crossbow builds: ursacomputing/crossbow @ actions-0e07cbb9ef

Task	Status
example-cpp-minimal-build-static
example-cpp-minimal-build-static-system-dependency
example-cpp-tutorial
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1
test-debian-12-cpp-amd64
test-debian-12-cpp-i386
test-fedora-42-cpp
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-20
test-ubuntu-22.04-cpp-bundled
test-ubuntu-22.04-cpp-emscripten
test-ubuntu-22.04-cpp-no-threading
test-ubuntu-24.04-cpp
test-ubuntu-24.04-cpp-bundled-offline
test-ubuntu-24.04-cpp-gcc-13-bundled
test-ubuntu-24.04-cpp-gcc-14
test-ubuntu-24.04-cpp-minimal-with-formats
test-ubuntu-24.04-cpp-thread-sanitizer

raulcd · 2025-11-28T11:59:47Z

@github-actions crossbow submit -g cpp

github-actions · 2025-11-28T12:02:24Z

Revision: a219eff

Submitted crossbow builds: ursacomputing/crossbow @ actions-b3962c3cec

Task	Status
example-cpp-minimal-build-static
example-cpp-minimal-build-static-system-dependency
example-cpp-tutorial
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1
test-cuda-cpp-ubuntu-24.04-cuda-13.0.2
test-debian-12-cpp-amd64
test-debian-12-cpp-i386
test-fedora-42-cpp
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-20
test-ubuntu-22.04-cpp-bundled
test-ubuntu-22.04-cpp-emscripten
test-ubuntu-22.04-cpp-no-threading
test-ubuntu-24.04-cpp
test-ubuntu-24.04-cpp-bundled-offline
test-ubuntu-24.04-cpp-gcc-13-bundled
test-ubuntu-24.04-cpp-gcc-14
test-ubuntu-24.04-cpp-minimal-with-formats
test-ubuntu-24.04-cpp-thread-sanitizer

raulcd · 2025-11-28T12:39:01Z

@github-actions crossbow submit -g r

github-actions · 2025-11-28T12:41:55Z

Revision: a219eff

Submitted crossbow builds: ursacomputing/crossbow @ actions-ada8c5b28b

Task	Status
r-binary-packages
r-recheck-most
test-r-arrow-backwards-compatibility
test-r-depsource-bundled
test-r-depsource-system
test-r-dev-duckdb
test-r-devdocs
test-r-extra-packages
test-r-gcc-11
test-r-gcc-12
test-r-install-local
test-r-install-local-minsizerel
test-r-linux-as-cran
test-r-linux-rchk
test-r-linux-sanitizers
test-r-linux-valgrind
test-r-m1-san
test-r-macos-as-cran
test-r-minimal-build
test-r-offline-maximal
test-r-offline-minimal
test-r-rhub-debian-gcc-devel-lto-latest
test-r-rhub-ubuntu-gcc12-custom-ccache
test-r-rhub-ubuntu-release-latest
test-r-rocker-r-ver-latest
test-r-rstudio-r-base-4.1-focal
test-r-rstudio-r-base-4.2-focal
test-r-ubuntu-22.04
test-r-versions

cpp/cmake_modules/ThirdpartyToolchain.cmake

kou · 2025-11-29T02:20:33Z

cpp/cmake_modules/ThirdpartyToolchain.cmake

+  if(PROTOBUF_VENDORED)
+    set(_gRPC_PROTOBUF_LIBRARIES
+        "protobuf::libprotobuf"
+        CACHE STRING "" FORCE)


Can we use normal variable not cache variable for all gRPC related variables?

@kou the only one that seems necessary is the one here: 00a838f
see the current CI failures, I can revert that one.
The rest doesn't seem necessary even though I have to investigate why gRPC_SSL_PROVIDER fails locally for me if I don't put CACHE (all CI is successful so might be that I miss to install something locally).

Thanks for checking it!

Let's use CACHE only for needed variables.

We may be able to remove CACHE by using OVERRIDE_FIND_PACKAGE in FetchContent_Declare() https://cmake.org/cmake/help/latest/module/FetchContent.html#integrating-with-find-package but it's out-of-scope of this PR.

raulcd · 2025-12-01T19:39:54Z

@github-actions crossbow submit test-ubuntu-22.04-cpp-bundled

github-actions · 2025-12-01T19:42:10Z

Revision: 8ad3a02

Submitted crossbow builds: ursacomputing/crossbow @ actions-98b88d65ce

Task	Status
test-ubuntu-22.04-cpp-bundled

raulcd · 2025-12-01T20:03:04Z

@github-actions crossbow submit -g r -g cpp

github-actions · 2025-12-01T20:06:29Z

Revision: 8ad3a02

Submitted crossbow builds: ursacomputing/crossbow @ actions-47316e024f

Task	Status
example-cpp-minimal-build-static
example-cpp-minimal-build-static-system-dependency
example-cpp-tutorial
r-binary-packages
r-recheck-most
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1
test-cuda-cpp-ubuntu-24.04-cuda-13.0.2
test-debian-12-cpp-amd64
test-debian-12-cpp-i386
test-fedora-42-cpp
test-r-arrow-backwards-compatibility
test-r-depsource-bundled
test-r-depsource-system
test-r-dev-duckdb
test-r-devdocs
test-r-extra-packages
test-r-gcc-11
test-r-gcc-12
test-r-install-local
test-r-install-local-minsizerel
test-r-linux-as-cran
test-r-linux-rchk
test-r-linux-sanitizers
test-r-linux-valgrind
test-r-m1-san
test-r-macos-as-cran
test-r-minimal-build
test-r-offline-maximal
test-r-offline-minimal
test-r-rhub-debian-gcc-devel-lto-latest
test-r-rhub-ubuntu-gcc12-custom-ccache
test-r-rhub-ubuntu-release-latest
test-r-rocker-r-ver-latest
test-r-rstudio-r-base-4.1-focal
test-r-rstudio-r-base-4.2-focal
test-r-ubuntu-22.04
test-r-versions
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-20
test-ubuntu-22.04-cpp-bundled
test-ubuntu-22.04-cpp-emscripten
test-ubuntu-22.04-cpp-no-threading
test-ubuntu-24.04-cpp
test-ubuntu-24.04-cpp-bundled-offline
test-ubuntu-24.04-cpp-gcc-13-bundled
test-ubuntu-24.04-cpp-gcc-14
test-ubuntu-24.04-cpp-minimal-with-formats
test-ubuntu-24.04-cpp-thread-sanitizer

raulcd · 2025-12-02T09:51:34Z

@github-actions crossbow submit -g r -g cpp

github-actions · 2025-12-02T09:54:51Z

Revision: 296882c

Submitted crossbow builds: ursacomputing/crossbow @ actions-5a84cfaf82

Task	Status
example-cpp-minimal-build-static
example-cpp-minimal-build-static-system-dependency
example-cpp-tutorial
r-binary-packages
r-recheck-most
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1
test-cuda-cpp-ubuntu-24.04-cuda-13.0.2
test-debian-12-cpp-amd64
test-debian-12-cpp-i386
test-fedora-42-cpp
test-r-arrow-backwards-compatibility
test-r-depsource-bundled
test-r-depsource-system
test-r-dev-duckdb
test-r-devdocs
test-r-extra-packages
test-r-gcc-11
test-r-gcc-12
test-r-install-local
test-r-install-local-minsizerel
test-r-linux-as-cran
test-r-linux-rchk
test-r-linux-sanitizers
test-r-linux-valgrind
test-r-m1-san
test-r-macos-as-cran
test-r-minimal-build
test-r-offline-maximal
test-r-offline-minimal
test-r-rhub-debian-gcc-devel-lto-latest
test-r-rhub-ubuntu-gcc12-custom-ccache
test-r-rhub-ubuntu-release-latest
test-r-rocker-r-ver-latest
test-r-rstudio-r-base-4.1-focal
test-r-rstudio-r-base-4.2-focal
test-r-ubuntu-22.04
test-r-versions
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-20
test-ubuntu-22.04-cpp-bundled
test-ubuntu-22.04-cpp-emscripten
test-ubuntu-22.04-cpp-no-threading
test-ubuntu-24.04-cpp
test-ubuntu-24.04-cpp-bundled-offline
test-ubuntu-24.04-cpp-gcc-13-bundled
test-ubuntu-24.04-cpp-gcc-14
test-ubuntu-24.04-cpp-minimal-with-formats
test-ubuntu-24.04-cpp-thread-sanitizer

raulcd · 2025-12-02T10:59:33Z

I think this is ready for review again! Thanks @kou

kou

+1

cpp/cmake_modules/ThirdpartyToolchain.cmake

raulcd · 2025-12-03T09:23:13Z

@github-actions crossbow submit -g r -g cpp

github-actions · 2025-12-03T09:26:22Z

Revision: 66e8062

Submitted crossbow builds: ursacomputing/crossbow @ actions-e7d62ed8db

Task	Status
example-cpp-minimal-build-static
example-cpp-minimal-build-static-system-dependency
example-cpp-tutorial
r-binary-packages
r-recheck-most
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1
test-cuda-cpp-ubuntu-24.04-cuda-13.0.2
test-debian-12-cpp-amd64
test-debian-12-cpp-i386
test-fedora-42-cpp
test-r-arrow-backwards-compatibility
test-r-depsource-bundled
test-r-depsource-system
test-r-dev-duckdb
test-r-devdocs
test-r-extra-packages
test-r-gcc-11
test-r-gcc-12
test-r-install-local
test-r-install-local-minsizerel
test-r-linux-as-cran
test-r-linux-rchk
test-r-linux-sanitizers
test-r-linux-valgrind
test-r-m1-san
test-r-macos-as-cran
test-r-minimal-build
test-r-offline-maximal
test-r-offline-minimal
test-r-rhub-debian-gcc-devel-lto-latest
test-r-rhub-ubuntu-gcc12-custom-ccache
test-r-rhub-ubuntu-release-latest
test-r-rocker-r-ver-latest
test-r-rstudio-r-base-4.1-focal
test-r-rstudio-r-base-4.2-focal
test-r-ubuntu-22.04
test-r-versions
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-20
test-ubuntu-22.04-cpp-bundled
test-ubuntu-22.04-cpp-emscripten
test-ubuntu-22.04-cpp-no-threading
test-ubuntu-24.04-cpp
test-ubuntu-24.04-cpp-bundled-offline
test-ubuntu-24.04-cpp-gcc-13-bundled
test-ubuntu-24.04-cpp-gcc-14
test-ubuntu-24.04-cpp-minimal-with-formats
test-ubuntu-24.04-cpp-thread-sanitizer

conbench-apache-arrow · 2025-12-18T05:20:29Z

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit dcfb211.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

github-actions bot added Component: C++ Component: FlightRPC awaiting committer review Awaiting committer review labels Nov 25, 2025

github-actions bot removed the Component: FlightRPC label Nov 26, 2025

raulcd force-pushed the GH-48248 branch from d458a43 to 9bddf67 Compare November 26, 2025 15:42

raulcd added the CI: Extra Run extra CI label Nov 26, 2025

raulcd force-pushed the GH-48248 branch 2 times, most recently from 84f2f87 to a219eff Compare November 28, 2025 11:30

raulcd marked this pull request as ready for review November 28, 2025 13:52

raulcd requested a review from kou November 28, 2025 13:52

kou reviewed Nov 29, 2025

View reviewed changes

github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Nov 29, 2025

apacheGH-48248: [C++] Use FetchContent for bundled gRPC

59dfa02

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Dec 1, 2025

Validate gRPC_CARES_PROVIDER needs CACHE variable clean

00a838f

github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Dec 1, 2025

Move back gRPC_CARES_PROVIDER to CACHE STRING FORCE

711662f

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Dec 2, 2025

Fix for Debian forky?

296882c

raulcd requested a review from kou December 2, 2025 10:59

kou approved these changes Dec 3, 2025

View reviewed changes

cpp/cmake_modules/ThirdpartyToolchain.cmake Show resolved Hide resolved

github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Dec 3, 2025

Add back CARES_BUILD_TOOLS OFF

66e8062

github-actions bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Dec 3, 2025

raulcd merged commit dcfb211 into apache:main Dec 3, 2025
63 of 64 checks passed

raulcd removed the awaiting changes Awaiting changes label Dec 3, 2025

raulcd mentioned this pull request Dec 3, 2025

[C++] Use FetchContent for bundled gRPC #48248

Closed

raulcd deleted the GH-48248 branch December 3, 2025 11:01

Conversation

raulcd commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

raulcd commented Nov 25, 2025

Uh oh!

github-actions bot commented Nov 25, 2025

Uh oh!

raulcd commented Nov 25, 2025

Uh oh!

github-actions bot commented Nov 25, 2025

Uh oh!

raulcd commented Nov 26, 2025

Uh oh!

github-actions bot commented Nov 26, 2025

Uh oh!

raulcd commented Nov 26, 2025

Uh oh!

github-actions bot commented Nov 26, 2025

Uh oh!

raulcd commented Nov 26, 2025

Uh oh!

github-actions bot commented Nov 26, 2025

Uh oh!

raulcd commented Nov 26, 2025

Uh oh!

github-actions bot commented Nov 26, 2025

Uh oh!

raulcd commented Nov 28, 2025

Uh oh!

github-actions bot commented Nov 28, 2025

Uh oh!

raulcd commented Nov 28, 2025

Uh oh!

github-actions bot commented Nov 28, 2025

Uh oh!

Uh oh!

Uh oh!

kou Nov 29, 2025

Choose a reason for hiding this comment

Uh oh!

raulcd Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

kou Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

raulcd commented Dec 1, 2025

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

raulcd commented Dec 1, 2025

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

raulcd commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

raulcd commented Dec 2, 2025

Uh oh!

kou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

raulcd commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 3, 2025

Uh oh!

Uh oh!

conbench-apache-arrow bot commented Dec 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

raulcd commented Nov 25, 2025 •

edited

Loading