MINOR: [C++][Parquet] Fix *_write_page_index and set_size_statistics_level comments#48299
Merged
wgtmac merged 2 commits intoapache:mainfrom Dec 3, 2025
Merged
MINOR: [C++][Parquet] Fix *_write_page_index and set_size_statistics_level comments#48299wgtmac merged 2 commits intoapache:mainfrom
wgtmac merged 2 commits intoapache:mainfrom
Conversation
Defaults were changed in this commit apache@1fcc892
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
wgtmac
approved these changes
Dec 2, 2025
Member
|
Could you fix the lint error? |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 0879f5b. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Defaults were changed in this commit 1fcc892
What changes are included in this PR?
Fixed comments about default values of some writer properties
Are these changes tested?
No need to test
Are there any user-facing changes?
No