Skip to content

GH-48402: [Python] Enable the relative path in test_write_dataset#48403

Merged
adamreeve merged 1 commit intoapache:mainfrom
HyukjinKwon:GH-48402
Dec 16, 2025
Merged

GH-48402: [Python] Enable the relative path in test_write_dataset#48403
adamreeve merged 1 commit intoapache:mainfrom
HyukjinKwon:GH-48402

Conversation

@HyukjinKwon
Copy link
Copy Markdown
Member

@HyukjinKwon HyukjinKwon commented Dec 9, 2025

Rationale for this change

Enable a test that is intended so.

What changes are included in this PR?

This PR proposes to enable the relative path in test_write_dataset with pyarrow.tests.util.change_cwd.

Are these changes tested?

Manually tested with pytest -k "test_write_dataset"

Are there any user-facing changes?

No, test-only.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 9, 2025

⚠️ GitHub issue #48402 has been automatically assigned in GitHub to PR creator.

@HyukjinKwon
Copy link
Copy Markdown
Member Author

Hi @jorisvandenbossche, it was added in 8813eac. Would you mind taking a quick look when you find some time please?

Copy link
Copy Markdown
Contributor

@adamreeve adamreeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HyukjinKwon

@adamreeve adamreeve merged commit 8fcab2f into apache:main Dec 16, 2025
14 checks passed
@adamreeve adamreeve removed the awaiting review Awaiting review label Dec 16, 2025
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Dec 16, 2025
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 8fcab2f.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 11 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants