GH-15047: [Python]: switch from pytz to zoneinfo by default for string to tzinfo conversion#49694
Open
jorisvandenbossche wants to merge 5 commits intoapache:mainfrom
Open
GH-15047: [Python]: switch from pytz to zoneinfo by default for string to tzinfo conversion#49694jorisvandenbossche wants to merge 5 commits intoapache:mainfrom
jorisvandenbossche wants to merge 5 commits intoapache:mainfrom
Conversation
… string to tzinfo conversion
|
|
Member
Author
|
@github-actions crossbow submit test-pandas |
|
Revision: dc184fe Submitted crossbow builds: ursacomputing/crossbow @ actions-cdf269df89
|
Member
Author
|
@github-actions crossbow submit -g python |
|
Revision: c2c973a Submitted crossbow builds: ursacomputing/crossbow @ actions-02d567dab2
|
Member
Author
|
@github-actions crossbow submit -g wheel |
|
Revision: c2c973a Submitted crossbow builds: ursacomputing/crossbow @ actions-4c3b50812b
|
4 tasks
Member
Author
|
As far as I can see, all failures in the above crossbow builds (after the last update) are unrelated (docker/git/download failures) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
zoneinfois available starting with Python 3.9, so we can now assume that it is available, and so we can switch from returningpytztimezones by default to returnzoneinfotimezones (ordatetime.timezonefor fixed offsets).Only keeping pytz as fallback for strings that are not supported by
zoneinfobut were supported bypytz. Later, we should maybe deprecate that fallback.Generally we should move away from using
pytz, since the core functionality of having time zones is now available in the standard library (zoneinfo), and because the pytz package has several warts / incompatibilities with stdlib datetime (https://blog.ganssle.io/articles/2018/03/pytz-fastest-footgun.html)What changes are included in this PR?
Whenever we create a python timezone object, which is when converting to pandas or when converting to a
datetime.datetimeobject:zoneinfofordatetime.datetimeobjectszoneinfofor pandas objects if pandas >= 3, to align with the change on the pandas side (API: Default to stdlib timezone objects instead of pytz pandas-dev/pandas#34916)In either case, when preferring
zoneinfo, we still fall back topytzfor named timezones ifzoneinfodoes not recognize the zone name (apparently pytz can have some common (older) aliases that might not always work with zoneinfo).This fallback is something we could deprecate and remove later on (so we can eventually remove all usage of pytz)
Are these changes tested?
Yes
Are there any user-facing changes?
This PR includes breaking changes to public APIs.
It is a different object that we return (different class, i.e.
zoneinfo.ZoneInfoinstead of apytz.tzinfo.BaseTzInfo, both are still subclasses ofdatetime.tzinfo), which has some differences in the API, so for people relying on that, this is a breaking change.For the conversion to pandas, pandas itself has made this breaking change anyhow, so for those cases it aligns with that change of pandas.