Conversation
Adds example of testing for stability / variance.
|
A preview of is uploaded and can be seen here: ✨ https://burr.dagworks.io/pull/489 ✨ Changes may take a few minutes to propagate. Since this is a preview of production, content with |
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to cb28888 in 1 minute and 25 seconds
More details
- Looked at
32lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. examples/pytest/README.md:314
- Draft comment:
jsonis used but not imported. Addimport jsonat the beginning of the code snippet. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
This is a code snippet in a README.md file, not actual implementation code. Documentation often omits imports for brevity. The code is meant to illustrate a concept rather than be directly copy-pasted. Additionally, this is a minor issue that would be immediately caught by any Python interpreter or linter if someone tried to run it.
The comment is technically correct - the code does use json without importing it. Missing imports could confuse readers who are new to Python.
While technically correct, this level of detail is unnecessary in documentation. The focus should be on the concept being illustrated, not implementation details that would be obvious when actually implementing.
Delete the comment. Missing imports in documentation examples are common and acceptable, and this would be immediately caught by tools if implemented.
Workflow ID: wflow_wvsiGGiYoaTYwSgC
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds example of testing for stability / variance.
Changes
How I tested this
Notes
Checklist
Important
Adds a section in
README.mdfor testing output stability/variance in generative models using pytest.README.mdfor testing stability/variance of outputs in generative models using pytest.test_an_actions_stability()to run actions multiple times and check output consistency.This description was created by
for cb28888. It will automatically update as commits are pushed.