Merged
Conversation
Updates the badges to remove deprecated one
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 534d466 in 1 minute and 19 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. README.md:9
- Draft comment:
Deprecated 'AI-Code Agent' badge removed. Confirm that its removal does not affect any integrations. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
2. README.md:10
- Draft comment:
Updated LinkedIn URL from 'dagster' to 'dagworks-inc'. Verify that this URL is correct for the intended LinkedIn showcase. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
3. README.md:10
- Draft comment:
Removal of the deprecated AI-Code Agent badge looks intentional. Please ensure that any related references in the documentation are updated accordingly. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
4. README.md:11
- Draft comment:
For security best practices, consider adding rel="noopener noreferrer" to anchor tags with target="_blank" to prevent potential tab-napping vulnerabilities. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50%
While the security suggestion is technically correct and a good practice, this is a README.md file with simple social media/badge links. The risk of tab-napping from these types of links is extremely low. The comment feels overly cautious for this context and doesn't meaningfully improve security given these are just social media badges.
I could be underestimating the security risk - any external link could potentially be dangerous. Also, implementing the suggestion is very low effort.
While the fix is easy, we should maintain a reasonable balance between security and practicality. For a README with simple social media links, this feels like security theater rather than meaningful protection.
The comment should be removed as it suggests an overly cautious security measure for a very low-risk context of social media badge links in a README file.
Workflow ID: wflow_Jhe9CmIq1kVxQBwH
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
A preview of is uploaded and can be seen here: ✨ https://burr.dagworks.io/pull/513 ✨ Changes may take a few minutes to propagate. Since this is a preview of production, content with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the badges to remove deprecated one
Changes
How I tested this
Notes
Checklist
Important
Update
README.mdto remove deprecated badge and update LinkedIn link.dagworks-inc.This description was created by
for 534d466. It will automatically update as commits are pushed.