Skip to content

Adds some spaces for multi-line strings#531

Merged
elijahbenizzy merged 1 commit intomainfrom
minor-spacing-issue
Apr 20, 2025
Merged

Adds some spaces for multi-line strings#531
elijahbenizzy merged 1 commit intomainfrom
minor-spacing-issue

Conversation

@elijahbenizzy
Copy link
Contributor

@elijahbenizzy elijahbenizzy commented Apr 19, 2025

Left out of a prior PR


Important

Adds spaces in a multi-line string in _validate_actions() in burr/core/graph.py for readability.

  • Code Style:
    • Adds spaces in a multi-line string in _validate_actions() in burr/core/graph.py for improved readability.

This description was created by Ellipsis for 2b6bcb5. You can customize this summary. It will automatically update as commits are pushed.

@github-actions
Copy link

github-actions bot commented Apr 19, 2025

A preview of is uploaded and can be seen here:

https://burr.dagworks.io/pull/531

Changes may take a few minutes to propagate. Since this is a preview of production, content with draft: true will not be rendered. The source is here: https://github.com/DAGWorks-Inc/burr/tree/gh-pages/pull/531/

@elijahbenizzy elijahbenizzy marked this pull request as ready for review April 20, 2025 16:51
@elijahbenizzy elijahbenizzy merged commit 213fd3f into main Apr 20, 2025
11 checks passed
@elijahbenizzy elijahbenizzy deleted the minor-spacing-issue branch April 20, 2025 16:52
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 2b6bcb5 in 28 seconds. Click for details.
  • Reviewed 15 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. burr/core/graph.py:33
  • Draft comment:
    Good improvement: added spaces to avoid concatenated words in multi-line string.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. burr/core/graph.py:33
  • Draft comment:
    The updated error message now correctly adds spaces between concatenated string literals. Consider using a single triple-quoted string for clarity and avoiding accidental spacing issues in the future.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
3. burr/core/graph.py:76
  • Draft comment:
    The docstring for _render_graphviz contains a typographical error on line 76: 'Use .pipe()` to not produce a not file; can't open the image'. This is confusing—it likely meant to say something like 'to not produce a dot file' or simply 'to not produce a file' when using .pipe(). Please review and correct the wording for clarity.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. burr/core/graph.py:265
  • Draft comment:
    There's a typographical error in the GraphBuilder class docstring on line 265 where 'ApplicationBuidler' is used instead of 'ApplicationBuilder'. Please fix the spelling.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_UDhfoGCvIKw7CO31

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants