Adds some spaces for multi-line strings#531
Merged
elijahbenizzy merged 1 commit intomainfrom Apr 20, 2025
Merged
Conversation
|
A preview of is uploaded and can be seen here: ✨ https://burr.dagworks.io/pull/531 ✨ Changes may take a few minutes to propagate. Since this is a preview of production, content with |
skrawcz
approved these changes
Apr 20, 2025
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 2b6bcb5 in 28 seconds. Click for details.
- Reviewed
15lines of code in1files - Skipped
0files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. burr/core/graph.py:33
- Draft comment:
Good improvement: added spaces to avoid concatenated words in multi-line string. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. burr/core/graph.py:33
- Draft comment:
The updated error message now correctly adds spaces between concatenated string literals. Consider using a single triple-quoted string for clarity and avoiding accidental spacing issues in the future. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. burr/core/graph.py:76
- Draft comment:
The docstring for _render_graphviz contains a typographical error on line 76: 'Use .pipe()` to not produce a not file; can't open the image'. This is confusing—it likely meant to say something like 'to not produce a dot file' or simply 'to not produce a file' when using .pipe(). Please review and correct the wording for clarity. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. burr/core/graph.py:265
- Draft comment:
There's a typographical error in the GraphBuilder class docstring on line 265 where 'ApplicationBuidler' is used instead of 'ApplicationBuilder'. Please fix the spelling. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_UDhfoGCvIKw7CO31
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Left out of a prior PR
Important
Adds spaces in a multi-line string in
_validate_actions()inburr/core/graph.pyfor readability._validate_actions()inburr/core/graph.pyfor improved readability.This description was created by
for 2b6bcb5. You can customize this summary. It will automatically update as commits are pushed.