Fix unportable scripts on macOS #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ray-Eldath
force-pushed
the
fix-greenplum_path
branch
3 times, most recently
from
ba0d41c to
d00051c
Compare
Ray-Eldath
changed the title
Ray-Eldath
force-pushed
the
fix-greenplum_path
branch
3 times, most recently
from
6a27543 to
5d5dd4b
Compare
Ray-Eldath
force-pushed
the
fix-greenplum_path
branch
3 times, most recently
from
75d9a3d to
e0ab34e
Compare
Contributor
Author
|
This PR is ready for review as it has sucessfully build demo cluster on both clean-installed Intel Mac and Apple M1 Mac. |
Baowen648
reviewed
Sep 21, 2023
Contributor
Baowen648
left a comment
Baowen648
left a comment
There was a problem hiding this comment.
We reset the system in intel and M1, and it has been verified that cbdb compilation, installation, cluster startup and icw test can be completed
Ray-Eldath
force-pushed
the
fix-greenplum_path
branch
from
e0ab34e to
1c0d6e2
Compare
Contributor
Author
|
I think I met the same |
tuhaihe
approved these changes
Sep 21, 2023
Member
tuhaihe
left a comment
tuhaihe
left a comment
There was a problem hiding this comment.
I was able to successfully build CloudberryDB on macOS/m1 using this branch. Thank you for your hard work! @Ray-Eldath 🫶🏻
Baowen648
approved these changes
Sep 22, 2023
1. Regarding greenplum_path.sh: In some platforms (notably macOS), various Python installations may co-exist. When demo_cluster.sh creates segments using ssh, it may not run by the same Python installation as the coordinator because env are not passed through, causing the super weird "Module 'pgdb' not found" error. This PR fix this by probing the path of the Python installation and write it down in greenplum_path.sh 2. README.macOS.bash and gp_bash_functions.sh are changed as well to properly create cluster on macOS.
Ray-Eldath
force-pushed
the
fix-greenplum_path
branch
from
1c0d6e2 to
2e8b741
Compare
8 tasks
Member
|
Hi @my-ship-it, could you please help review this pull request? Once it's approved, we can announce the new feature. Thank you! |
baotingfang
pushed a commit
that referenced
this pull request
Dec 1, 2023
1. Regarding greenplum_path.sh: In some platforms (notably macOS), various Python installations may co-exist. When demo_cluster.sh creates segments using ssh, it may not run by the same Python installation as the coordinator because env are not passed through, causing the super weird "Module 'pgdb' not found" error. This PR fix this by probing the path of the Python installation and write it down in greenplum_path.sh 2. README.macOS.bash and gp_bash_functions.sh are changed as well to properly create cluster on macOS.
Ray-Eldath
added a commit
to Ray-Eldath/cloudberrydb
that referenced
this pull request
Mar 1, 2024
Current greenplum_path.sh is a result of apache#201 to make greenplum_path.sh always using the Python during ./configure. But it inadvertently changes user's $PATH. This portion of apache#201 is reverted, and it should be fine if user use pip install --user to install dependencies.
Merged
2 tasks
foreyes
pushed a commit
to foreyes/cloudberrydb
that referenced
this pull request
Jul 8, 2024
Current greenplum_path.sh is a result of apache#201 to make greenplum_path.sh always using the Python during ./configure. But it inadvertently changes user's $PATH. This portion of apache#201 is reverted, and it should be fine if user use pip install --user to install dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change logs
Fix unportable scripts on macOS
greenplum_path.sh: In some platforms (notably macOS), various Python installations may co-exist. Whendemo_cluster.shcreates segments using ssh, it may not run by the same Python installation as the coordinator because env are not passed through, causing the super weird"Module 'pgdb' not found"error. This PR fix this by probing the path of the Python installation and write it down ingreenplum_path.sh.README.macOS.bashandgp_bash_functions.share changed as well to properly create cluster on macOS.Why are the changes needed?
Important
This PR is a by-product of #198. These two PR are necessary to support CBDB building and running on macOS platform.
Does this PR introduce any user-facing change?
Before this PR, user cannot run
make create-demo-clusteron macOS. Now they can.