Skip to content

Feature: Orca optimizor support pax storage table #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gfphoenix78 merged 1 commit into from
Dec 27, 2023
+13 −0
Merged

Feature: Orca optimizor support pax storage table #346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/backend/gpopt/translate/CTranslatorRelcacheToDXL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2433,6 +2433,19 @@ CTranslatorRelcacheToDXL::RetrieveRelStorageType(Relation rel)
case HEAP_TABLE_AM_OID:
rel_storage_type = IMDRelation::ErelstorageHeap;
break;
// FIXME: need to add support for custom table am!!!
//
// Why 7014 here?
// Because we defined a custom table am using columnar storage,
// the orca optimizer does not support am other than HEAP/AO/AOCS. At present,
// there is no way to extend orca to support custom table am. So here we use
// the am_id(7014) we assigned to the custom table am, and let the orca optimizer
// treat this columnar storage format as AOCS to generate an execution plan
//
// Why use the magic number 7014 instead of the macro definition?
// Just to make it look like it doesn't make sense,
// so others will notice that the logic needs to be refactored
case 7014:
case AO_COLUMN_TABLE_AM_OID:
rel_storage_type = IMDRelation::ErelstorageAppendOnlyCols;
break;
Expand Down