Skip to content

Conversation

@jiaqizho
Copy link
Contributor

@jiaqizho jiaqizho commented Feb 27, 2024

Change logs

Add some tests and a benchmark in interconnect module.

The test of the interconnect and the benchmark can be run independently of CBDB, also need to be compiled separately.

Benchmark can be used to measure the performance of different interconnect implementations in the current network environment. but for now, only single client + single server is supported in testing and benchmark.

More information: contrib/interconnect/README.md

Why are the changes needed?

none

Does this PR introduce any user-facing change?

nope

How was this patch tested?

nope

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

@jiaqizho jiaqizho requested a review from my-ship-it February 27, 2024 06:13
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@my-ship-it my-ship-it merged commit 9519f02 into apache:main Feb 28, 2024
foreyes pushed a commit to foreyes/cloudberrydb that referenced this pull request Jul 8, 2024
The test of the interconnect and the benchmark can be run independently of CBDB, also need to be compiled separately.

Benchmark can be used to measure the performance of different interconnect implementations in the current
network environment. but for now, only single client + single server is supported in testing and benchmark.

More information: contrib/interconnect/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants