Skip to content

default build postgres_fdw #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
my-ship-it merged 1 commit into from
Apr 1, 2024
Merged

default build postgres_fdw #400

my-ship-it merged 1 commit into from
Apr 1, 2024

Conversation

@smartyhero
Copy link
Contributor

@smartyhero smartyhero commented Mar 29, 2024

fix #ISSUE_Number

Change logs

default build postgres_fdw

Why are the changes needed?

want directly use postgres_fdw

Does this PR introduce any user-facing change?

Users can directly use create extension postgres_fdw

How was this patch tested?

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

@smartyhero smartyhero closed this Apr 1, 2024
@smartyhero smartyhero reopened this Apr 1, 2024
my-ship-it
my-ship-it approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@my-ship-it my-ship-it merged commit 2e16543 into apache:main Apr 1, 2024
foreyes pushed a commit to foreyes/cloudberrydb that referenced this pull request Jul 8, 2024
@smartyhero @my-ship-it
Enable postgres_fdw by default (apache#400)
81a8c0a 
Currenty postgres_fdw regression test already pass, so enable it in Makefile
@my-ship-it
Copy link
Contributor

my-ship-it commented Oct 9, 2024

Fix #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@my-ship-it my-ship-it my-ship-it approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smartyhero @my-ship-it