Skip to content

Conversation

@congxuebin
Copy link
Contributor

fix #487


In the UOS 1050a aarch64 operating system, there are slight differences in the storage space occupied by table data and the compression ratio compared to other systems. Therefore, modify test cases to validate pg_relation_size and get_ao_compression_ratio within a ±10% expected range.

Outlined below are two modifications.

select
    case
        when
            abs((pg_relation_size('mpp17012_compress_test2') - 712.0) / 712.0) < 0.1
        then 'test passed'
        else 'test failed'
    end as test_relation_size;
 test_relation_size 
--------------------
 test passed
(1 row)

select
    case
        when
            abs((get_ao_compression_ratio('mpp17012_compress_test2') - 36.75) / 36.75) < 0.1
        then 'test passed'
        else 'test failed'
    end as test_ao_compression_ratio;
 test_ao_compression_ratio 
---------------------------
 test passed
(1 row)
select
    case
        when
            abs((pg_relation_size('a_aoco_table_with_rle_type_compression') - 296.0) / 296.0) < 0.1
        then 'test passed'
        else 'test failed'
    end as test_relation_size;

select
    case
        when
            abs((get_ao_compression_ratio('a_aoco_table_with_rle_type_compression') - 1.81) / 1.81) < 0.1
        then 'test passed'
        else 'test failed'
    end as test_ao_compression_ratio;

@congxuebin
Copy link
Contributor Author

congxuebin commented Jul 4, 2024

@tuhaihe Dianjin, it appears pipeline failed before ICW, could you please help?

@tuhaihe
Copy link
Member

tuhaihe commented Jul 4, 2024

Hey, @congxuebin: had retriggered the pipelines again.

@congxuebin
Copy link
Contributor Author

@tuhaihe Hi Dianjin, thanks for retriggering it. But it failed again at check out step.

@congxuebin
Copy link
Contributor Author

congxuebin commented Jul 4, 2024

@tuhaihe Dianjin, it appears the git runner issue has resolved, could you please re-trigger this pipeline? Thanks in advance.

@congxuebin
Copy link
Contributor Author

congxuebin commented Jul 5, 2024

@tuhaihe

The test case that I modified has successfully executed via the pipeline. But it failed on something else.

AOCO_Compression ... ok 28984 ms (diff 219 ms)

Could you please help re-trigger the ICW? or actually it should be ok to move forward instead if is possible.

@congxuebin
Copy link
Contributor Author

Hi Max @my-ship-it ,

The test case I modified ran successfully via this pipeline, but the pipeline failed due to something else. I don't think it's worth another rerun for this.

AOCO_Compression ... ok 28984 ms (diff 219 ms)

I heard reviewer has super authority to directly merge code change. Would you please review it, if approved, proceed with the merge?

@tuhaihe
Copy link
Member

tuhaihe commented Jul 8, 2024

@congxuebin: I have help retrigger the pipelines again. Don't worry, the pr will be merged only after passing all the tests.

@congxuebin congxuebin requested a review from my-ship-it July 8, 2024 06:26
@congxuebin
Copy link
Contributor Author

Thanks. All checks have passed.

@my-ship-it
Copy link
Contributor

@congxuebin Please don't use Merge branch

…t_ao_compression_ratio within ±10% expected range according to issue apache#487
@congxuebin
Copy link
Contributor Author

congxuebin commented Jul 10, 2024

@tuhaihe Hi Dianjin, my test case succeeded.

AOCO_Compression ... ok 26721 ms (diff 219 ms)

Would you please help to re-trigger the pipeline as it failed on something else? Thanks.

@tuhaihe
Copy link
Member

tuhaihe commented Jul 10, 2024

@congxuebin Sure, re-triggered the test again. If still failed, plz let me know.

@avamingli avamingli merged commit be38ff5 into apache:main Jul 11, 2024
foreyes pushed a commit to foreyes/cloudberrydb that referenced this pull request Sep 20, 2024
change AOCO_Compression test case to validate pg_relation_size and get_ao_compression_ratio within ±10%
expected range according to issue apache#487 (apache#493)

Co-authored-by: congxuebin <[email protected]>
(cherry picked from commit be38ff5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [uos1050a:aarch64 only] pg_relation_size and get_ao_compression_ratio slightly different from other operating system

4 participants