Skip to content

Fix compile error in c++20 #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gfphoenix78 merged 1 commit into from
Jul 10, 2024
Merged

Fix compile error in c++20 #510

gfphoenix78 merged 1 commit into from
Jul 10, 2024

Conversation

@gfphoenix78
Copy link
Contributor

@gfphoenix78 gfphoenix78 commented Jul 9, 2024 •
edited
Loading

In c++20, more constraints are applied:

  • constructor and destructor are not allowed to have template id
  • adding two enum value needs explicit convertion

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

@gfphoenix78
Fix compile error in c++20
e0483b0 
In c++20, more constraints are applied:

* constructor and destructor are not allowed to have template id
* adding two enum value needs explicit convertion
@gfphoenix78 gfphoenix78 requested a review from avamingli July 10, 2024 01:41
@gfphoenix78 gfphoenix78 merged commit 1e70fdc into apache:main Jul 10, 2024
@gfphoenix78 gfphoenix78 deleted the fix-cpp-c++20 branch July 10, 2024 02:44
foreyes pushed a commit to foreyes/cloudberrydb that referenced this pull request Sep 20, 2024
@gfphoenix78 @fanfuxiaoran
Fix compile error in c++20 (apache#510)
f148fc1 
In c++20, more constraints are applied:

* constructor and destructor are not allowed to have template id
* adding two enum value needs explicit convertion

(cherry picked from commit 1e70fdc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avamingli avamingli avamingli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gfphoenix78 @avamingli