Skip to content

Conversation

@gfphoenix78
Copy link
Contributor

AC_FUNC_FSEEKO macro doesn't use ac_cv_func_fseeko in configure.ac and we have to force HAVE_FSEEKO to 1. The pg upstream has cleared this part of script, but cbdb doesn't.

Reference:
postgres/postgres@799d224 https://www.postgresql.org/message-id/200802190116.m1J1GcZ28086%40momjian.us

fix #516

Why are the changes needed?

configure will report a warning/error. This commit fixes the issue and aligns the code with pg upstream.

Does this PR introduce any user-facing change?

No

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

AC_FUNC_FSEEKO macro doesn't use ac_cv_func_fseeko in
configure.ac and we have to force HAVE_FSEEKO to 1. The pg
upstream has cleared this part of script, but cbdb doesn't.

Reference:
postgres/postgres@799d224
https://www.postgresql.org/message-id/200802190116.m1J1GcZ28086%40momjian.us
@gfphoenix78 gfphoenix78 merged commit 6ba54ad into apache:main Aug 6, 2024
congxuebin pushed a commit to congxuebin/cloudberrydb that referenced this pull request Aug 7, 2024
AC_FUNC_FSEEKO macro doesn't use ac_cv_func_fseeko in
configure.ac and we have to force HAVE_FSEEKO to 1. The pg
upstream has cleared this part of script, but cbdb doesn't.

Reference:
postgres/postgres@799d224
https://www.postgresql.org/message-id/200802190116.m1J1GcZ28086%40momjian.us
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] configure development script generates an 'sh' shell error due to an initialized variable (ac_cv_func_fseeko)

2 participants