delete hightlight and downplay doc#279
Conversation
|
|
||
| **Attention: ** The `?:` note in the code shows that this attribute is optional. *EVENT:* stands for the event that triggers action. | ||
|
|
||
| ## highlight(Action) |
There was a problem hiding this comment.
We shouldn't remove them as they are still working for other series or components.
The v5 upgrade guide indicates that the highlight action & downplay action in the sunburst series are deprecated but not in all series.
Perhaps we should add new actions for sunburstHighlight & sunburstUnhighlight.
|
@pissang Please help review this PR. |
|
As @plainheart said, this change is only scoped to the sunburst series, it should be mentioned in the note |
|
I was confused because It should be. deprecateReplaceLog('sunburstHighlight', 'highlight');So we should change this warning log instead of changing the doc |
|
It is stated in the V5 upgrade document that this is discarded in the sunrise chart,please check again 旭日图(sunburst): |
|
apache/echarts#17587 is following the right track. I think there should be no document changing required so I'm going to close this PR. Thanks for the help! |
fix issues#185