Skip to content

fix(types): fix SunburstSeriesOption and TreemapSeriesOption types #17218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ovilia merged 1 commit into from
Jun 16, 2022
+3 −3
Merged

fix(types): fix SunburstSeriesOption and TreemapSeriesOption types #17218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/chart/sunburst/SunburstSeries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export interface SunburstSeriesNodeItemOption extends
StatesOptionMixin<SunburstStateOption<CallbackDataParams>, SunburstStatesMixin>,
OptionDataItemObject<OptionDataValue>
{
nodeClick?: 'rootToNode' | 'link'
nodeClick?: 'rootToNode' | 'link' | false
// Available when nodeClick is link
link?: string
target?: string
Expand Down Expand Up @@ -138,7 +138,7 @@ export interface SunburstSeriesOption extends
*/
// highlightPolicy?: 'descendant' | 'ancestor' | 'self'

nodeClick?: 'rootToNode' | 'link'
nodeClick?: 'rootToNode' | 'link' | false

renderLabelForZeroData?: boolean

Expand Down
2 changes: 1 addition & 1 deletion src/chart/treemap/TreemapSeries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ export interface TreemapSeriesOption
* be on left depth, the behaviour would be changing root. Otherwise
* use behavious defined above.
*/
nodeClick?: 'zoomToNode' | 'link'
nodeClick?: 'zoomToNode' | 'link' | false

breadcrumb?: BoxLayoutOptionMixin & {
show?: boolean
Expand Down