Skip to content

chore: fix publish ci on fork#17245

Merged
plainheart merged 2 commits intomasterfrom
fix-publish-ci-on-fork
Jun 20, 2022
Merged

chore: fix publish ci on fork#17245
plainheart merged 2 commits intomasterfrom
fix-publish-ci-on-fork

Conversation

@pissang
Copy link
Contributor

@pissang pissang commented Jun 19, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Avoid running nightly version publish workflow on the forks. See ecomfe/zrender#928

Merging options

  • Please squash the commits into a single one when merging.

@echarts-bot
Copy link

echarts-bot bot commented Jun 19, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: PR: doc ready, PR: awaiting doc, PR: doc unchanged

This message is shown because the PR description doesn't contain the document related template.

@plainheart
Copy link
Member

The stale and source-release may be also unnecessary.

@echarts-bot
Copy link

echarts-bot bot commented Jun 19, 2022

To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: PR: doc ready, PR: awaiting doc, PR: doc unchanged

This message is shown because the PR description doesn't contain the document related template.

@pissang
Copy link
Contributor Author

pissang commented Jun 19, 2022

@plainheart Thanks for the reminding. Just added

@echarts-bot
Copy link

echarts-bot bot commented Jun 20, 2022

To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: PR: doc ready, PR: awaiting doc, PR: doc unchanged

This message is shown because the PR description doesn't contain the document related template.

@plainheart plainheart merged commit 0f9f16c into master Jun 20, 2022
@echarts-bot
Copy link

echarts-bot bot commented Jun 20, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart deleted the fix-publish-ci-on-fork branch June 20, 2022 01:29
@Ovilia Ovilia added this to the 5.4.0 milestone Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants