Skip to content

fix(pie): fix labelLine may not be hidden when minShowLabelRadian is specified#17412

Merged
Ovilia merged 1 commit intomasterfrom
fix-pie-labelLine
Jul 22, 2022
Merged

fix(pie): fix labelLine may not be hidden when minShowLabelRadian is specified#17412
Ovilia merged 1 commit intomasterfrom
fix-pie-labelLine

Conversation

@plainheart
Copy link
Member

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix a bug that when minShowLabelRadian is specified and the sector angle is less than it, the labelLine doesn't be hidden.

Fixed issues

Details

Before: What was the problem?

After: How does it behave after the fixing?

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Please refer to the last case in test/pie-label.html.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jul 21, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart plainheart requested a review from pissang July 21, 2022 08:36
@plainheart plainheart added this to the 5.4 milestone Jul 21, 2022
@Ovilia Ovilia merged commit 67afcbd into master Jul 22, 2022
@echarts-bot
Copy link

echarts-bot bot commented Jul 22, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants