Skip to content

fix(custom): set ignore only if old child exists #17450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ovilia merged 3 commits into from
Aug 1, 2022
Merged

fix(custom): set ignore only if old child exists #17450

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f22be19
fix(custom): set ignore only if old child exists
Ovilia Aug 1, 2022
1eb1394
fix(custom): add assert to give more detailed information
Ovilia Aug 1, 2022
68e8fc3
style(custom): new line
Ovilia Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/chart/custom/CustomView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1340,6 +1340,13 @@ function mergeChildren(
);
}
else {
if (__DEV__) {
assert(
oldChild,
'renderItem should not return a group containing elements'
+ ' as null/undefined/{} if they do not exist before.'
);
}
// If the new element option is null, it means to remove the old
// element. But we cannot really remove the element from the group
// directly, because the element order may not be stable when this
Expand Down