GRAILS-9280: Various issues with DetachedCriteria and Where queries

[graemerocher]

Original Reporter: longwa
Environment: Testing on Windows 7, x64, Grails 2.1.0
Version: 2.1
Migrated From: http://jira.grails.org/browse/GRAILS-9280

This ticket is the parent for several slightly different (but possibly) related sub-issues regarding the new Where and DetachedCriteria support.

Specifically:

• findAll and withCriteria can take similar closures and quietly return different results (SQL has invalid 1=1)
• findAll quietly ignores criteria on associations referenced via the Closure syntax
• findAll quietly ignores criteria on any properties accessed via more than one association A.B.C == 'foo' (SQL has invalid 1=1 where clause)
• findAll throws an exception if comparing a property to a property on an associated domain (prop == B.prop)
• findAll throws an exception if using the Closure syntax to reference associations more than one level deep.
• where() chaining ignores criteria unless the chained query is in the same scope (defining a DetachedCriteria on the domain and then chaining elsewhere silently ignores the additional criteria)

[graemerocher]

longwa said:
One of the issues in the list above (the 5th bullet point) may be a duplicate of GRAILS-8256. I included it here because the attached bug report includes tests which demonstrate the issue.

[graemerocher]

chriserickson said:
Although the problem may have been more related to chaining than anything else. It is hard to remember at this point.

[graemerocher]

longwa said:
Thanks for the clarifications. You are right, #4 is supported using the Criteria syntax and aliases as a workaround without using HQL.

[graemerocher]

longwa said:
Ah, yeah, that sounds different. I'd search around for a matching ticket and if you can't find one, create a new ticket (with a test app and the failing test).

[graemerocher]

pledbrook said:
I think it would be worth someone familiar with this issue updating the description and possibly title to cover what needs doing after all these comments. Or perhaps new issues should be raised for the problems that have been identified? For example, "Where queries should not compile if Criteria syntax used".