Fix for GRAILS-4621: Validation errors not read from message bundle for POJO domain entities#7
Closed
beskow wants to merge 3 commits intoapache:masterfrom
beskow:master
Closed
Fix for GRAILS-4621: Validation errors not read from message bundle for POJO domain entities#7beskow wants to merge 3 commits intoapache:masterfrom beskow:master
beskow wants to merge 3 commits intoapache:masterfrom
beskow:master
Conversation
…or POJO domain entities - Corrected AbstractGrailsHibernateTests to set mainContext for grailsApplication - Added unit test to verify a GrailsHibernateDomainClass' verifier has a messageSource - Modified GrailsHibernateDomainClass to have a grailsApplication injected in its constructor, and use it to retrieve the messageSource - Modified GrailsHibernateUtils to pass the grailsApplication instance to GrailsHibernateDomainClasses
Contributor
|
Could you update: MessageSource messageSource = (MessageSource) application.getMainContext().getBean("messageSource"); To be: MessageSource messageSource = application.getMainContext().getBean(MessageSource.class); Which is better as it doesn't depend on the bean name. |
Author
|
Good point, Graeme. Updated and pushed as 601b5cf. |
Contributor
|
Applied. Thanks. |
jdaugherty
pushed a commit
to jdaugherty/grails-core
that referenced
this pull request
Jan 7, 2025
Update consuming.adoc
jdaugherty
pushed a commit
to jdaugherty/grails-core
that referenced
this pull request
Jan 9, 2025
Upgraded commons-lang to 3.0
jdaugherty
pushed a commit
to jdaugherty/grails-core
that referenced
this pull request
Feb 9, 2025
Binding autotimestamp fields
jdaugherty
pushed a commit
that referenced
this pull request
May 1, 2025
….develocity-3.19.2 Bump com.gradle.develocity from 3.19.1 to 3.19.2
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation error messages are not read from message bundle when using POJO (EJB3-annotated) domain entities, since their validator lacks a messageSource reference. Hence all validation error messages always use the default messages in english. In a I18n-enabled application, that is not acceptable.
This commit fixes the problem by
In JpaMappedDomainTests, a test is added to verify that GrailsHibernateDomainClass' verifier has a messageSource.
In order for the unit tests in JpaMappedDomainTests to run clean, the AbstractGrailsHibernateTests is fixed to correctly set the mainContext property of the grailsApplication.