Removed gradle 'application' plugin from the application template#423
Merged
jamesfredley merged 5 commits intoapache:7.0.xfrom Nov 9, 2024
Merged
Removed gradle 'application' plugin from the application template#423jamesfredley merged 5 commits intoapache:7.0.xfrom
jamesfredley merged 5 commits intoapache:7.0.xfrom
Conversation
Contributor
|
@gsartori You will also need to update |
Contributor
Author
|
Thank you for the hint, it should be okay now |
matrei
approved these changes
Nov 8, 2024
| then: | ||
| buildGradle.contains('mainClass.set("example.grails.Application")') | ||
|
|
||
| where: |
Contributor
There was a problem hiding this comment.
Should the test name be updated to reflect that the Application class no longer is referenced in build.gradle?
Contributor
Author
There was a problem hiding this comment.
I guess so, I've updated it
jamesfredley
approved these changes
Nov 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Gradle "application" plugin is not required by a Spring Boot application, it was introduced in the Grails app template with the inclusion of Micronaut.
From the Gradle user guide:
I propose to remove the plugin, as part of a cleanup effort, since this is not the way we are using it in a Grails application.