Merged
Conversation
Contributor
Author
|
Thanks to @rwr This has been released (and verified) in |
skrawcz
reviewed
Jul 12, 2024
skrawcz
reviewed
Jul 12, 2024
skrawcz
approved these changes
Jul 12, 2024
Contributor
skrawcz
left a comment
skrawcz
left a comment
There was a problem hiding this comment.
just need minor changes...
elijahbenizzy
force-pushed
the
async-updates
branch
from
cf5118a to
f035ed8
Compare
See #1023. High-level: 1. We computed the set of nodes to calculate 2. In async we did not count overrides 3. The directly overridden nodes were not computed but their upstream dependencies *were* 4. This fixes that The test tests at the execute and not raw_execute() level, as that is more indicative of the contract.
See #1022. What was happening: 1. We were assuming the .result_builder variable was set 2. It was never, it's defunct 3. Thus we were checking that, and adding a result builder 4. This would result in a double one This fixes it by: 1. Checking for any result builders in the adapters 2. If there is one, let the AsyncDriver interface handle it 3. Otherwise, pass in a DictResult()
This allows creating it in a non-async setting. You'll have to initialize it later. This was a request from a user who didn't want to convert their entire stack to async (as driver construction was buried down). It's a very reasonable power-user feature.
elijahbenizzy
force-pushed
the
async-updates
branch
from
f035ed8 to
8e9a5ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test tests at the execute and not raw_execute() level, as that is more indicative of the contract.
Changes
How I tested this
Notes
Checklist