fix: updated imports for polars extension 1.0.0#1031
Merged
elijahbenizzy merged 1 commit intomainfrom Jul 17, 2024
Merged
Conversation
elijahbenizzy
approved these changes
Jul 17, 2024
Contributor
elijahbenizzy
left a comment
There was a problem hiding this comment.
Thanks for the fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polars upgrading to
>= 1.0.0introduced breaking changes, in particular going frompolars.typing_aliasestopolars._typing.We made changes accordingly, but missed two imports that were within a materializer definition. The warning is triggered when the materializer is registered during extension loading. This explains why we missed it and it wasn't covered by our tests.
Also, I renamed
polars_post_1_0_0_extension.pyto the pluralpolars_post_1_0_0_extensions.pyto match convention.