CI fixes because other packages break other packages#1233
Merged
Conversation
dask-expr library is now needed.
plotly/Kaleido#226 is the issue. We just need to wait.
Since not worth fixing.
Contributor
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to afd93d3 in 42 seconds
More details
- Looked at
61lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .ci/test.sh:31
- Draft comment:
Consider using a more explicit version check for clarity:
if python -c 'import sys; exit(0) if sys.version_info >= (3, 9) else exit(1)'; then
- Reason this comment was not posted:
Confidence changes required:50%
The PR adds a version check for Python 3.9+ in the test script and test cases, which is a good practice to ensure compatibility. However, the version check in the test script uses a comparison that might not be intuitive at first glance. It would be clearer to use a more explicit comparison for readability.
Workflow ID: wflow_eOExZTSDVU7JndPF
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
elijahbenizzy
approved these changes
Nov 18, 2024
Contributor
elijahbenizzy
left a comment
There was a problem hiding this comment.
This will get easier if we drop 3.8 support, right? It's EOL officially now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for CI.
Contains 1 temporary fix around plotly.
Changes
How I tested this
Notes
Checklist