Marks xfail xgboost test due to scikit lib issue#1255
Merged
elijahbenizzy merged 2 commits intomainfrom Dec 12, 2024
Merged
Conversation
Skips because we're seeing: > AttributeError: 'super' object has no attribute '__sklearn_tags__' due to new library version rolling out and xgboost not being updated yet.
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to c2c3b03 in 17 seconds
More details
- Looked at
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. tests/plugins/test_xgboost_extensions.py:37
- Draft comment:
Thexfailmark is applied withcondition=True, meaning the test is expected to fail unconditionally. Ensure to revisit this once the library incompatibility is resolved. - Reason this comment was not posted:
Confidence changes required:50%
The xfail mark is applied with condition=True, which means it will always expect the test to fail. This is appropriate given the PR description, but it should be noted that this is a temporary measure until the library incompatibility is resolved.
2. tests/plugins/test_xgboost_extensions.py:38
- Draft comment:
Function and method names should follow consistent patterns. Consider renamingtest_xgboost_model_json_readerand other test functions to maintain consistency in naming conventions. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_EapOU3s7moOMiY8d
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
elijahbenizzy
approved these changes
Dec 12, 2024
So new version of numpy doesn't have the same behavior for 3.9 as for 3.10+.
Contributor
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 3060b64 in 31 seconds
More details
- Looked at
32lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. tests/test_node.py:63
- Draft comment:
Consider using more descriptive variable names formajorandminor, such asnumpy_major_versionandnumpy_minor_version, to improve code readability. This applies to line 48 as well. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_EhsVp2uCVlE6onWA
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| node = Node.from_fn(annotated_func) | ||
| assert node.name == "annotated_func" | ||
| if major == 2 and minor > 1: # greater that 2.1 | ||
| if major == 2 and minor > 1 and sys.version_info > (3, 9): # greater that 2.1 |
Contributor
There was a problem hiding this comment.
The condition sys.version_info > (3, 9) should be sys.version_info >= (3, 9) to correctly include Python 3.9 and above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skips because we're seeing:
Changes
How I tested this
Notes
Checklist