Adds a few more SQL commands for snowflake example#1258
Merged
Conversation
Also fixes typo.
Contributor
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 22c0c86 in 33 seconds
More details
- Looked at
45lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. examples/snowflake/hamilton_ui/pipeline_endpoint.py:89
- Draft comment:
Fixed logical bug: Corrected the order of parameters when creating pandas Series for 'signups' and 'spend'. This fix is also applicable to line 90. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_o9kE2q132Uip6UX0
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a few more SQL commands for snowflake example
Changes
How I tested this
Notes
Checklist