Replaces most links and Hamilton references#1339
Conversation
c1e7948 to
4312df5
Compare
e87eba8 to
b256e29
Compare
b256e29 to
d4d31cc
Compare
This does not replace the hamilton.dagworks.io links until we have hamilton.apache.org set up and running.
I spot checked this.
This does a few things: 1. Adds .github workflow to build things 2. Adds .asf.yaml that specifies that a site should be built and deployed. No real design decisions, other than this seems to work and is low effort. Squashed commits below: Adds to asf.yaml and attempts to write to docs to branch (+4 squashed commits) Squashed commits: [e44ca55] Adds incubating reference [486c57f] Adds pushing to asf-* branches Will see if this works. [4312df5] Fixes docs and creates PDF [919ccc2] Adds github workflow to build docs WIP commit.
This change updates links to the right documentation domain.
60bd0ce to
eed2e88
Compare
Was getting a too shallow warning. Gemini suggested increasing the fetch depth - so I set it to 0 to check out the whole repo.
7145b05 to
242cf8d
Compare
242cf8d to
5d8fd01
Compare
|
@apache/hamilton-committers I think the docs are in a reasonable state to commit. There's more work to get the apache things we need in, but I've done a lot of changes here that I think are good enough to commit. I'd squash merge this PR with a nice commit upon approval. |
|
note: the unit tests are failing due to some kedro library change... |
elijahbenizzy
left a comment
There was a problem hiding this comment.
Should we use Hamilton or Apache Hamilton when referring to the core features? I.E. the library's name isn't changing -- it's still a "Hamilton Node" not an "Apache HAmilton Node"? Otherwise looks good.
jernejfrank
left a comment
There was a problem hiding this comment.
Just a minor comment/question on the domain from my side since I saw that some files already use https://hamilton.apache.org/
I missed these domain changes. Note the docs don't have en/latest/ on them.
Since in most cases Hamilton suffices when describing concepts within Hamilton.
0af0934 to
a319142
Compare
|
@elijahbenizzy @jernejfrank I think I addressed your concerns. |
|
@skrawcz guidance on naming: |
Yes. I'm not going to go through the docs with a fine toothed comb here. I err'ed on the side of too much Apache Hamilton. Which I think is fine. We can always adjust this as we touch and read the docs... |
|
LGTM, I will let @elijahbenizzy approve |
This replaces all links with the right ones.
Changes
How I tested this
Notes
Checklist